Skip to content
Snippets Groups Projects

3424925 - Removed color flicker when custom accent color is used.

Open 3424925 - Removed color flicker when custom accent color is used.
issue/gin-3424925:8.x-3.x into 8.x-3.x
1 unresolved thread
Open Tanmay Khedekar requested to merge issue/gin-3424925:8.x-3.x into 8.x-3.x
1 unresolved thread

For 3424925 - Color flicker when a custom color is used.

Edited by Tanmay Khedekar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matt Glaman
  • Matt Glaman
    Matt Glaman @mglaman ·

    If gin/gin_accent is needed, can we just add it as an #attached in gin_preprocess_html if needed

  • Tanmay Khedekar added 1 commit

    added 1 commit

    • 5a575262 - 3424925 - Removed unnecessary dependencies.

    Compare with previous version

  • Tanmay Khedekar
    Tanmay Khedekar @tanmayk ·
    Author

    @mglaman Agreed. Both dependencies were not needed.

  • Tanmay Khedekar resolved all threads

    resolved all threads

  • Matt Glaman
    Matt Glaman @mglaman started a thread on the diff
    • templates/html.html.twig
    37 37 <head-placeholder token="{{ placeholder_token }}">
    38 38 <title>{{ head_title|safe_join(' | ') }}</title>
    39 39 <css-placeholder token="{{ placeholder_token }}">
    40 {% if gin_custom_colors %}
    41 <style class="gin-custom-colors">
    42 {{ gin_custom_colors }}
    43 </style>
    44 {% endif %}
    • Comment on lines +40 to +44
      Matt Glaman
      Matt Glaman @mglaman ·

      While manually testing, the live preview of accent colors worked. But we should make sure it's updating this style element if it exists versus adding a new one on the bottom. Or maybe it doesn't really matter.

      But the JavaScript could be duplicating this once the accent color is saved. So I suppose we should double check

    • Please register or sign in to reply
  • Matt Glaman
  • Matt Glaman
  • Tanmay Khedekar added 1 commit

    added 1 commit

    • 1f99723b - 3424925 - Fixed shaded color function.

    Compare with previous version

  • Tanmay Khedekar added 1 commit

    added 1 commit

    • 245da827 - 3424925 - Changed helper methods to be static.

    Compare with previous version

    • Please register or sign in to reply