Skip to content
Snippets Groups Projects

CommonMap fix to take positions from views row

DataProviderBase::getPositionsFromViewsRow() does not honor its own name because it does not take the positions from the Views Row, but instead it takes the entity from the row (within DataProviderBase::getFieldItemsFromViewsRow()) and get all positions from the entity field regardless of the views row data.

That might make sense when we want to group all values in the same row (checking that option in the field settings), but not when we want each value in a different row, and maybe filter those results as in the proposed scenario.

We should take the position from the row data if it's available, and show all the entity values only when the option of grouping all values in the row has been set

Merge request reports

Merge train pipeline #90813 passed with warnings

Merge train pipeline passed with warnings for 7bd76e9c

Approval is optional

Merged by Christian AdamskiChristian Adamski 1 year ago (Feb 8, 2024 7:54pm UTC)

Merge details

  • Changes merged into 2.x with 7bd76e9c (commits were squashed).
  • Did not delete the source branch.

Pipeline #91000 passed with warnings

Pipeline passed with warnings for 7bd76e9c on 8.x-3.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading