fix: resolve phpstan and rector deprecation warnings

Stuart Clarkrequested to merge
fix/lint-phpstan-rector-deprecations into 8.x-1.x

Summary

Fixes PHPStan and Rector deprecation/config errors blocking CI, and applies all resulting Rector transformations.

PHPStan

  • src/Redirect.php: Inject EntityTypeManagerInterface instead of storing the storage object (entityStoragePropertyAssignment).

Rector config

  • rector.php: Removed deprecated rules (CountArrayToEmptyArrayComparisonRector, DisallowedEmptyRuleFixerRector)
  • rector.php: Replaced broken Drupal9/10/11SetList constants with DrupalSetProvider + withComposerBased(drupal: TRUE), fixing crashes from removed rector/rector constants (PHPUNIT_90, TWIG_24, SYMFONY_63)

Rector-applied code changes

  • 17 test files: Added #[RunTestsInSeparateProcesses] attribute (modernizing @runTestsInSeparateProcesses annotation)
  • 3 source files: Simplified double-negated boolean conditions via De Morgan's laws
  • 2 files: Added : int return type to REQUIREMENT_ERROR closures
Edited by Stuart Clark

Merge request reports