Issue #3512119 by joseph.olstad: Deprecated function: Creation of dynamic...

Issue #3512119 by joseph.olstad: Deprecated function: Creation of dynamic property externalhost line 60 of src/Filebrowser.php

Closes #3512119

src/Filebrowser.php

@@ -42,6 +42,7 @@ class Filebrowser {
   public $gridWidth;
   public $gridHideTitle;
   public $externalHost;
+  public $externalhost;
 
   /**
    * Filebrowser constructor.
@@ -57,6 +58,9 @@ class Filebrowser {
      // $this->folderPathEncoded = $node_settings['folder_path_encoded'];
       $properties = unserialize($node_settings['properties']);
       foreach ($properties as $property => $value) {
+        if ($property == 'externalhost') {
+          $property = 'externalHost';
+        }
         $this->$property = $value;
       }
     }

[Joseph Olstad]

This is required, otherwise the unserialize on line 58 throws a Deprecated function: Creation of dynamic properties. This is part 2 of a 2 part fix.

[Joseph Olstad]

part 1 of a 2 part fix.

[Joseph Olstad]

Camel case is favoured as a pattern in this class, forward/backwards compatibility fix. Data left over from 1x /2x installs massaged for compatibility with the 3.1.x class.