Draft: Resolve #3234526 "Fielduiextras project open"

Review changes
Download
Patches
Plain diff

Closed Draft: Resolve #3234526 "Fielduiextras project open"

issue/field_ui_extras-3234526:3234526-fielduiextras-project-open into 8.x-1.x

Overview 0
Commits 6
Pipelines 0
Changes 7

Closed Matt Obert requested to merge issue/field_ui_extras-3234526:3234526-fielduiextras-project-open into 8.x-1.x 3 years ago

Overview 0
Commits 6
Pipelines 0
Changes 7

This MR is enough to pass the automated Rector tests, but D9 compatibility is still far off.

The remaining problem is in field_ui_extras/src/FieldUiExtrasFieldConfigListBuilder.php.

The FieldUiExtrasFieldConfigListBuilder constructor has the wrong parameters.

Comparing the parameters for public function FieldConfigListBuilder::__construct in 8.x and 9.x APIs, it looks like the EntityManagerInterface has been replaced by the EntytyTypeManagerInterface and the EntityFieldManagerInterface.

But it's not enough to update the parameters here.

I do like the idea of extending the Field UI, but this approach needs work.

Draft: Closes #3234526

Edited 3 years ago by Matt Obert

Merge request reports

Activity

Filter activity

Approvals
Assignees & reviewers
Comments (from bots)
Comments (from users)
Commits & branches
Edits
Labels
Lock status
Mentions
Merge request status
Tracking

Please register or sign in to reply

0 Assignees

0 Reviewers

Request review from

Labels

None

Select labels

Manage project labels

Milestone

None

Time tracking

No estimate or time spent

0 Participants

There are currently no pipelines.

To run a merge request pipeline, the jobs in the CI/CD configuration file must be configured to run in merge request pipelines and you must have sufficient permissions in the source project.