Skip to content
Snippets Groups Projects

Issue #3396241: Can't create an entity after all its fields decryption and module removal

Issue #3396241: Can't create an entity after all its fields decryption and module removal
issue/field_encrypt-3396241:3396241-cant-create-an into 3.1.x
1 open thread
Open
Roman Sychrequested to merge
issue/field_encrypt-3396241:3396241-cant-create-an into 3.1.x
1 open thread

Closes #3396241

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
field_encrypt.install
21 21 */
22 22 function field_encrypt_uninstall($is_syncing) {
23 23 \Drupal::state()->delete('field_encrypt.entity_types');
24
25 $field_storage_definitions = \Drupal::database()
  • Taras Kravchuk
    Taras Kravchuk @tarik

    We have several calls to the \Drupal::database() method, also this method will be called many times during the foreach() section. I believe it makes sense to add $database variable for the 'database' service and then replace all calls to \Drupal::database() with $database. So the result should look like:

    Suggested change
    25 $field_storage_definitions = \Drupal::database()
    25 $database = \Drupal::database();
    26 $field_storage_definitions = $database
  • Taras Korpach changed this line in version 2 of the diff

    changed this line in version 2 of the diff

  • Please register or sign in to reply
  • Taras Korpach added 1 commit

    added 1 commit

    • 8798fcf5 - Avoid unnecessary database accesses

    Compare with previous version

    • Please register or sign in to reply