fix: #3614921 Don't use storage as a class property (!255) · Merge requests · project / feeds

Storing entity storage on the object as a property (or injecting it directly instead of the entity type manager) is discouraged by PHPStan's Drupal rules, since the storage handler can change at runtime. Removed unused storage properties and replaced direct storage injection with EntityTypeManagerInterface, calling getStorage() at each call site.

FeedListBuilder/LogListBuilder keep direct storage injection because EntityListBuilder's constructor mandates it, and Text's $filter_format_storage keeps its type for the same BC reasons already tracked in #3473603. Both are now documented as phpstan.neon exceptions.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

Closes #3614921

fix: #3614921 Don't use storage as a class property

Merge request reports