commented on
merge request !26
"Ensure messenger is instantiated before it is required by any methods."
at
project / fastly
LGTM
commented on
merge request !26
"Ensure messenger is instantiated before it is required by any methods."
at
project / fastly
FWIW - The proposed changes look fine to me. It's just the shuffling of one line of code a bit higher up, before the possible early return in the c...
-
29486345 · Added typed config manager in all config forms.
commented on
merge request !27
"Added typed config manager in all config forms."
at
project / fastly
I've reviewed the patch, looks good. I'm merging it for 4.0.4.
commented on
merge request !30
"Apply fastly-Site_ID_is_not_visible-3444107-2.patch"
at
project / fastly
I've reviewed the patch, looks good. I'm merging it for 4.0.4.
accepted
merge request
!30
"Apply fastly-Site_ID_is_not_visible-3444107-2.patch"
at
project / fastly
-
0a5ed853 · Apply fastly-Site_ID_is_not_visible-3444107-2.patch
commented on
merge request !29
"Apply 3382993-fastly-settings-form-site-id-error-2.patch"
at
project / fastly
I've reviewed the patch, looks good....
accepted
merge request
!29
"Apply 3382993-fastly-settings-form-site-id-error-2.patch"
at
project / fastly
-
ec8dd4cd · Apply 3382993-fastly-settings-form-site-id-error-2.patch
opened
merge request
!29
"Apply 3382993-fastly-settings-form-site-id-error-2.patch"
at
project / fastly