Skip to content
Snippets Groups Projects
Märt Matsoo's avatar
commented on merge request !26 "Ensure messenger is instantiated before it is required by any methods." at project / fastly

LGTM

Märt Matsoo's avatar
commented on merge request !26 "Ensure messenger is instantiated before it is required by any methods." at project / fastly

FWIW - The proposed changes look fine to me. It's just the shuffling of one line of code a bit higher up, before the possible early return in the c...

Katsuyuki Omuro's avatar
pushed new tag 4.0.4 at project / fastly
Katsuyuki Omuro's avatar
accepted merge request !27 "Added typed config manager in all config forms." at project / fastly
Katsuyuki Omuro's avatar
pushed to branch 4.0.x-dev at project / fastly
  • 29486345 · Added typed config manager in all config forms.
Katsuyuki Omuro's avatar
approved merge request !27 "Added typed config manager in all config forms." at project / fastly
Katsuyuki Omuro's avatar
approved merge request !27 "Added typed config manager in all config forms." at project / fastly
Katsuyuki Omuro's avatar
commented on merge request !27 "Added typed config manager in all config forms." at project / fastly

I've reviewed the patch, looks good. I'm merging it for 4.0.4.

Katsuyuki Omuro's avatar
commented on merge request !30 "Apply fastly-Site_ID_is_not_visible-3444107-2.patch" at project / fastly

I've reviewed the patch, looks good. I'm merging it for 4.0.4.

Katsuyuki Omuro's avatar
deleted branch 3444107-fix-site-id-not-visible at project / fastly
Katsuyuki Omuro's avatar
accepted merge request !30 "Apply fastly-Site_ID_is_not_visible-3444107-2.patch" at project / fastly
Katsuyuki Omuro's avatar
pushed to branch 4.0.x-dev at project / fastly
  • 0a5ed853 · Apply fastly-Site_ID_is_not_visible-3444107-2.patch
Katsuyuki Omuro's avatar
opened merge request !30 "Apply fastly-Site_ID_is_not_visible-3444107-2.patch" at project / fastly
Katsuyuki Omuro's avatar
pushed new branch 3444107-fix-site-id-not-visible at project / fastly
Katsuyuki Omuro's avatar
commented on merge request !29 "Apply 3382993-fastly-settings-form-site-id-error-2.patch" at project / fastly

I've reviewed the patch, looks good....

Katsuyuki Omuro's avatar
deleted branch 3382993-initial-configuration-form-error at project / fastly
Katsuyuki Omuro's avatar
accepted merge request !29 "Apply 3382993-fastly-settings-form-site-id-error-2.patch" at project / fastly
Katsuyuki Omuro's avatar
pushed to branch 4.0.x-dev at project / fastly
  • ec8dd4cd · Apply 3382993-fastly-settings-form-site-id-error-2.patch
Katsuyuki Omuro's avatar
opened merge request !29 "Apply 3382993-fastly-settings-form-site-id-error-2.patch" at project / fastly
Katsuyuki Omuro's avatar
pushed new branch 3382993-initial-configuration-form-error at project / fastly