Skip to content
Snippets Groups Projects
Sascha Grossenbacher's avatar
opened merge request !7 "revert formatter weight change" at project / fallback_formatter
Adam G-H's avatar
Adam G-H's avatar
accepted merge request !6 "Issue #3485764: Remove dash from schema" at project / fallback_formatter
Jakob P's avatar
opened merge request !6 "Issue #3485764: Remove dash from schema" at project / fallback_formatter
Adam G-H's avatar
Adam G-H's avatar
  • e213af82 · Issue #3430427 by rajeshreeputra, Project Update Bot, baluertl, jap...
Adam G-H's avatar
accepted merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter
Adam G-H's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter
    // Apply the changes....
Adam G-H's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

OK - I'll commit it with this to ease upgrades, but can you open a follow-up to drop D9 support?

Jakob P's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

@phenaproxima respectfully disagree here, nearly 40% of users are still on Drupal 9.5. Thus its been our policy to keep Drupal 9.5 support, despite...

Jakob P's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

It should be 9.5, no need for a dependency of drupal:system.

Jakob P's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

This syntax is wrong. $default_weight + 1 != $default_weight++ ... This would make the weight = 1 for every formatter.

Pravin Gaikwad's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

This is changed to fix the TypeError: Unsupported operand types: string * int. More info in failed test result here.

Pravin Gaikwad's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

done, thank you for confirmation.

Pravin Gaikwad's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

Reverted.

Pravin Gaikwad's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

Done

Adam G-H's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

🤔 Why was this change needed? It's a subtle logic change, it looks like, but I'm not clear on why it was necessary for Drupal 11 compatibility.

Adam G-H's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

I think we might just want to drop Drupal 9 compatibility entirely; it's EOL.

Adam G-H's avatar
commented on merge request !5 "Fixes added manually on top of bot's changes" at project / fallback_formatter

This doesn't do what you think it does. waitForText() returns a boolean after waiting, so you also need to do something like this:...