tests/src/FunctionalJavascript/JsBase.php

 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\facets\FunctionalJavascript;
 
 use Drupal\block\Entity\Block;

tests/src/FunctionalJavascript/WidgetJSTest.php

 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\facets\FunctionalJavascript;
 
 use Drupal\facets\Entity\Facet;
@@ -11,26 +13,6 @@ use Drupal\facets\Entity\Facet;
  */
 class WidgetJSTest extends JsBase {
 
-  /**
-   * Tests JS interactions in the admin UI.
-   */
-  public function testAddFacet() {
-    $this->drupalGet('admin/config/search/facets/add-facet');
-
-    $page = $this->getSession()->getPage();
-
-    // Select one of the options from the facet source dropdown and wait for the
-    // result to show.
-    $page->selectFieldOption('edit-facet-source-id', 'search_api:views_page__search_api_test_view__page_1');
-    $this->getSession()->wait(6000, "jQuery('.facet-source-field-wrapper').length > 0");
-
-    $page->selectFieldOption('facet_source_configs[search_api:views_page__search_api_test_view__page_1][field_identifier]', 'type');
-
-    // Check that after choosing the field, the name is already filled in.
-    $field_value = $this->getSession()->getPage()->findField('edit-name')->getValue();
-    $this->assertEquals('Type', $field_value);
-  }
-
   /**
    * Tests show more / less links.
    */

tests/src/Unit/Plugin/processor/ListItemProcessorTest.php

@@ -42,7 +42,7 @@ class ListItemProcessorTest extends UnitTestCase {
    */
   protected $results;
 
-  protected $processor_plugin_manager;
+  protected $processorPluginManager;
 
   /**
    * Creates a new processor object for use in the tests.
@@ -103,8 +103,8 @@ class ListItemProcessorTest extends UnitTestCase {
       ->with('facets_facet')
       ->willReturn($facet_entity_type);
 
-    $this->processor_plugin_manager = $this->createMock(ProcessorPluginManager::class);
-    $this->processor_plugin_manager->method('getDefinitions')
+    $this->processorPluginManager = $this->createMock(ProcessorPluginManager::class);
+    $this->processorPluginManager->method('getDefinitions')
       ->willReturn(['list_item' => ['class' => ListItemProcessor::class]]);
 
     $event_dispatcher = $this->createMock(EventDispatcher::class);
@@ -112,7 +112,7 @@ class ListItemProcessorTest extends UnitTestCase {
     $container = new ContainerBuilder();
     $container->set('plugin.manager.facets.facet_source', $pluginManager);
     $container->set('entity_type.manager', $entity_type_manager);
-    $container->set('plugin.manager.facets.processor', $this->processor_plugin_manager);
+    $container->set('plugin.manager.facets.processor', $this->processorPluginManager);
     $container->set('event_dispatcher', $event_dispatcher);
     \Drupal::setContainer($container);
   }
@@ -145,7 +145,7 @@ class ListItemProcessorTest extends UnitTestCase {
     $entity_type_bundle_info = $this->createMock(EntityTypeBundleInfo::class);
 
     $processor = new ListItemProcessor([], 'list_item', [], $config_manager, $entity_field_manager, $entity_type_bundle_info);
-    $this->processor_plugin_manager->method('createInstance')
+    $this->processorPluginManager->method('createInstance')
       ->willReturn($processor);
 
     // Config entity field facet.
@@ -196,7 +196,7 @@ class ListItemProcessorTest extends UnitTestCase {
     $entity_type_bundle_info = $this->createMock(EntityTypeBundleInfo::class);
 
     $processor = new ListItemProcessor([], 'list_item', [], $config_manager, $entity_field_manager, $entity_type_bundle_info);
-    $this->processor_plugin_manager->method('createInstance')
+    $this->processorPluginManager->method('createInstance')
       ->willReturn($processor);
 
     // Config entity field facet.
@@ -251,7 +251,7 @@ class ListItemProcessorTest extends UnitTestCase {
     $entity_type_bundle_info = $this->createMock(EntityTypeBundleInfo::class);
 
     $processor = new ListItemProcessor([], 'list_item', [], $config_manager, $entity_field_manager, $entity_type_bundle_info);
-    $this->processor_plugin_manager->method('createInstance')
+    $this->processorPluginManager->method('createInstance')
       ->willReturn($processor);
 
     // Base prop facet.

tests/src/Unit/UrlProcessor/UrlProcessorPluginManagerTest.php

@@ -6,7 +6,6 @@ use Drupal\Component\Plugin\Discovery\DiscoveryInterface;
 use Drupal\Component\Plugin\Factory\DefaultFactory;
 use Drupal\Core\Cache\CacheBackendInterface;
 use Drupal\Core\Extension\ModuleHandlerInterface;
-use Drupal\Core\StringTranslation\TranslationInterface;
 use Drupal\facets\UrlProcessor\UrlProcessorPluginManager;
 use Drupal\Tests\UnitTestCase;
 

tests/src/Unit/Widget/WidgetPluginManagerTest.php

@@ -6,7 +6,6 @@ use Drupal\Component\Plugin\Discovery\DiscoveryInterface;
 use Drupal\Component\Plugin\Factory\DefaultFactory;
 use Drupal\Core\Cache\CacheBackendInterface;
 use Drupal\Core\Extension\ModuleHandlerInterface;
-use Drupal\Core\StringTranslation\TranslationInterface;
 use Drupal\facets\Widget\WidgetPluginManager;
 use Drupal\Tests\UnitTestCase;