#3459249: Handled context menu on right click

Handled Context menu on right click Disabled scroll when context menu open

https://www.loom.com/share/8abdc7fb97bc4815a71dc23bc4c197dc?sid=7a716a66-26a7-4022-8fa4-fc00eb97eb7d

requested review from @jessebaker

Thanks for this submission. I think the loss of being able to hover is a deal breaker - is that a limitation of this approach or do you think it can be worked around?

While working on !93 (merged) I had to remove the "hamburger" menu to make the outline match the designs and, as an interim solution I swapped the Radix dropdown to a Context Menu. In my version though, you can only right click the component name - it was not intended to be a final solution. Could the Radix Context Menu be useful to you?

Thanks @jessebaker. The Context Menu could be useful. Would it be possible to merge your merge request (MR) into the 0.x branch? This would allow me to handle and work around it accordingly.

added 1 commit

• 98de01bd - 3459249: addressed feedback, passed pagex and pagey, removed extra code

Compare with previous version

added 37 commits

• 98de01bd...e69b8399 - 35 commits from branch project:0.x
• 09f6c3b7 - 3459249: Handled context menu on right click
• 5ead9bbf - 3459249: addressed feedback, passed pagex and pagey, removed extra code

Compare with previous version

added 23 commits

• 5ead9bbf...25b99dc0 - 21 commits from branch project:0.x
• 9599bbb1 - 3459249: Handled context menu on right click
• d8dc9d90 - 3459249: addressed feedback, passed pagex and pagey, removed extra code

Compare with previous version

added 1 commit

• 6690c675 - Fix eslint and cspell.

Compare with previous version

added 1 commit

• f52d6ea6 - Fix outline styling and tests.

Compare with previous version

changed title from 3459249: Handled context menu on right click to #3459249: Handled context menu on right click

added 4 commits

• 6b30e5c9 - Issue #3467162 by Wim Leers, jessebaker, bnjmnm, f.mazeikis: Follow-up for...
• b5f93e57 - Issue #3467176 by Utkarsh_33, omkar-pd: Two requests sent to /api/preview/…, should be one
• 1274a009 - Issue #3456020 by bnjmnm, jessebaker, Wim Leers, larowlan: Harden Cypress E2E...
• 2af72282 - #345949: Fixed outline issue on the conponents

Compare with previous version

added 11 commits

• 2af72282...63743938 - 10 commits from branch project:0.x
• 578905a9 - Merge branch '0.x' into 3459249-contextual-menu-on-click

Compare with previous version

added 2 commits

• c6be42f7 - wip
• 7b98fbb9 - refactor right click menu into its own component and general tidy up

Compare with previous version

added 1 commit

• 6341a098 - Fixed - right click now also closes the menu. Fixed - small flash of the menu...

Compare with previous version

added 6 commits

• 6341a098...f3667563 - 5 commits from branch project:0.x
• 83b96988 - Merge remote-tracking branch 'origin/0.x' into 3459249-contextual-menu-on-click

Compare with previous version

added 1 commit

• 83b76503 - PrimaryMenuState defiend and fixed linting

Compare with previous version

added 1 commit

• a280d6e0 - Fixed ESlint warning

Compare with previous version

added 1 commit

• fc7bf101 - removing unused code

Compare with previous version

This is looking good. I have spotted one minor issue and we need some tests too.

The issue is as follows:

When opening the context menu in one spot and then closing it and opening it in another spot, the menu briefly flashes in the old location before jumping to the new location. It makes the menu feel a bit flickery.

This gif hopefully shows, in very very slow motion the issue (each red circle represents me right clicking). I click once to open the menu, then again to close it, then again to open it in a different place and you can see that for a frame the menu appears in the original location before moving to the correct location.

So in summary please

1. can we resolve the flicker issue or raise a follow up ticket to address it
2. add a test for the menu and the option inside it

requested changes

added 1 commit

• 3b3096a1 - removing unused code

Compare with previous version

assigned to @fazilitehreem

assigned to @Gauravmahlawat and @omkar-pd

added 1 commit

• c3fae5a6 - Fixed the flickering problem

Compare with previous version

added 48 commits

• c3fae5a6...62551621 - 46 commits from branch project:0.x
• 1d5e72a0 - Merging error
• b8524f9a - Added test

Compare with previous version

added 1 commit

• a174aa9d - Replaced rightclick() with trigger contextmenu

Compare with previous version

added 4 commits

• a174aa9d...ee1b8a9a - 2 commits from branch project:0.x
• 1d7dd104 - Merge branch '0.x' into 3459249-contextual-menu-on-click
• 4643f5a1 - Fix lint

Compare with previous version

added 1 commit

• d455ace1 - Added test for Delete function in context menu, attempt fix test failure

Compare with previous version

added 7 commits

• d455ace1...4bfe83fa - 6 commits from branch project:0.x
• f14a5e30 - Merge branch '0.x' into 3459249-contextual-menu-on-click

Compare with previous version

added 1 commit

• 081ddb1c - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 6 commits

• 081ddb1c...5d885a2b - 5 commits from branch project:0.x
• da365c37 - Merge branch '0.x' into '3459249-contextual-menu-on-click'

Compare with previous version

added 1 commit

• 5db45457 - fixed UI eslint error

Compare with previous version

approved this merge request

resolved all threads

added 4 commits

• 5db45457...3532fdc5 - 3 commits from branch project:0.x
• 59fd65c3 - Merge branch '0.x' into 3459249-contextual-menu-on-click

Compare with previous version

merged