Skip to content
Snippets Groups Projects

Add client.css to astro build

Merged Jesse Baker requested to merge issue/experience_builder-3509357:3509357-astro-css into 0.x
All threads resolved!

Closes #3509357

Two parts to this MR

  1. the addition of client.css to the Astro Hydration public directory that sets <astro-slot><astro-island> to be display: contents;. This is then included in the libraries.yml
  2. Changes to the calculation of
    1. border outlines around components, regions, slots in the overlay - now they are based on child elements of the <astro-*>
    2. stack direction calculation (used to show either vertical or horizontal lines when dragging in grid/flex based slots) now finds the parent of the <astro-slot>

In 2.1 and 2.2, the code actually looks for display: contents; not the <astro-x> tagName which should be more robust.

Spotted an issue to address in a follow up

https://www.drupal.org/project/experience_builder/issues/3521034

Edited by Jesse Baker

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jesse Baker added 1 commit

    added 1 commit

    Compare with previous version

  • Jesse Baker added 1 commit

    added 1 commit

    • f079bbfe - Refactor several functions to better take into consideration astro-* elements

    Compare with previous version

  • Jesse Baker
  • Jesse Baker marked this merge request as ready

    marked this merge request as ready

  • Jesse Baker changed the description

    changed the description

  • Jesse Baker added 22 commits

    added 22 commits

    Compare with previous version

  • Lee Rowlands resolved all threads

    resolved all threads

  • Jesse Baker added 8 commits

    added 8 commits

    Compare with previous version

  • Jesse Baker added 1 commit
  • Harumi Jang added 14 commits

    added 14 commits

    Compare with previous version

  • Harumi Jang approved this merge request

    approved this merge request

  • Harumi Jang added 4 commits

    added 4 commits

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading