Resolve #3518253 "Sdcs with optional"
Closes #3518253
Merge request reports
Activity
added 61 commits
-
9e4fb5a7...715f26b0 - 58 commits from branch
project:0.x - 45bee29a - Send a more useful error message.
- 1757645a - Allow the component input form to continue to render even if there are violations.
- bffb6b32 - Allow NULLs in DefaultRelativeUrlPropSource::evaluate().
Toggle commit list-
9e4fb5a7...715f26b0 - 58 commits from branch
added 30 commits
-
2a9309b3...ff3c502c - 18 commits from branch
project:0.x - ff3c502c...3ed9a31f - 2 earlier commits
- a681c6e6 - Allow NULLs in DefaultRelativeUrlPropSource::evaluate().
- 45924afd - Unused use statement.
- 4cb41656 - Skip SDC rendering if validation fails.
- 46f5af7f - Update comment.
- fa4489da - Rework.
- dd04750c - Fix spacing.
- 01f406dc - Make message more explicit.
- 62ba3ac6 - Be consistent with exception types.
- 4c22d6e9 - Remove dead code.
- 80050c14 - Simplify.
Toggle commit list-
2a9309b3...ff3c502c - 18 commits from branch
added 20 commits
-
4c1b9029...8ba2d18f - 7 commits from branch
project:0.x - 8ba2d18f...0d90b76f - 3 earlier commits
- fa8ac586 - Unused use statement.
- 09bea160 - Skip SDC rendering if validation fails.
- f1bde51c - Update comment.
- 5180bee5 - Rework.
- ad7bb832 - Fix spacing.
- 02ab11f7 - Make message more explicit.
- a6a1de1f - Be consistent with exception types.
- bab8b467 - Remove dead code.
- 9afd6e0c - Simplify.
- 8ce63c34 - Unused use statements.
Toggle commit list-
4c1b9029...8ba2d18f - 7 commits from branch
added 1 commit
- 4a950d32 - Add test coverage for optional image with heading SDC.
380 374 continue; 381 375 } 382 376 $component_prop = ComponentPropExpression::fromString($component_prop_expression); 383 $storable_props[] = $component_prop->propName; 384 } 385 foreach ($storable_props as $sdc_prop_name) { 398 388 $disabled = !$source instanceof DefaultRelativeUrlPropSource; 399 389 $source = $this->getDefaultStaticPropSource($sdc_prop_name)->withValue($prop_source_array['value'] ?? NULL); 400 390 } 391 } 392 elseif (!$is_required) { -
This is the actual fix here; optional props must be missing entirely from the array, and then SDC handles them correctly; if you pass NULL or an empty array then the prop is considered present but then the required
srcproperty is missing. So in the case of the SDC config form with an optional prop we need to fall back and provide the default prop source, because the client didn't send it at all.
added 10 commits
-
7e5695db...328b8a3c - 9 commits from branch
project:0.x - 832b2b01 - Merge remote-tracking branch 'origin/0.x' into 3518253-sdcs-with-optional
-
7e5695db...328b8a3c - 9 commits from branch
Please register or sign in to reply