#3458617: Close menu on drag in primary menu
Closes #3458617
This issue:
- Hides the submenu onDragStart by conditionally setting a
display: none
and then it actually closes it onDragEnd. If we just close the menu onDragStart, the draggable element gets dismounted from the DOM because we are closing the component and it results in an error. Two new reducers have been added touiSlice
to handle this. - User can now also close/open the submenu by clicking on the subtrigger ("Default components", "Custom components", "Section templates").
- Created a new
sidebar/primary/sub
directory and moved all submenu related components to there - Moved border color to use a variable in PrimaryMenubar.module.css
- Removes old unused primary panel code
Drag and drop test should be added after [ #3455942] is in.
Edited by Harumi Jang
Merge request reports
Activity
Filter activity
requested review from @jessebaker and @bnjmnm
added 1 commit
- 0bc9bd85 - Use variable for menu border color and remove extra pixel of thickness
added 5 commits
Toggle commit list- Resolved by Harumi Jang
- Resolved by Harumi Jang
- Resolved by Harumi Jang
requested review from @jessebaker and removed approval
- Resolved by Harumi Jang
removed review request for @bnjmnm and @jessebaker
assigned to @hooroomoo
added 8 commits
-
8a6c893c...a8fa36d9 - 2 commits from branch
project:0.x
- 61fc6616 - Close submenu onDrag and reopen onDragEnd and add onClick for submenu
- 66ef0499 - Add dependency to useCallback
- 5ab0d22d - Use variable for menu border color and remove extra pixel of thickness
- 9e6f1881 - Post-rebase add new container value to new submenu components
- 2cb199cc - Rename Subtrigger to SubmenuTrigger
- 23cf1aa2 - Close menu on drag by passing in setState to child component
Toggle commit list-
8a6c893c...a8fa36d9 - 2 commits from branch
Please register or sign in to reply