Skip to content
Snippets Groups Projects

#3458617: Close menu on drag in primary menu

Merged Harumi Jang requested to merge issue/experience_builder-3458617:3458617-ondrag into 0.x

Closes #3458617

This issue:

  • Hides the submenu onDragStart by conditionally setting a display: none and then it actually closes it onDragEnd. If we just close the menu onDragStart, the draggable element gets dismounted from the DOM because we are closing the component and it results in an error. Two new reducers have been added to uiSlice to handle this.
  • User can now also close/open the submenu by clicking on the subtrigger ("Default components", "Custom components", "Section templates").
  • Created a new sidebar/primary/sub directory and moved all submenu related components to there
  • Moved border color to use a variable in PrimaryMenubar.module.css
  • Removes old unused primary panel code

Drag and drop test should be added after [ #3455942] is in.

Edited by Harumi Jang

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Wim Leers
  • Wim Leers
  • Wim Leers requested review from @jessebaker and removed approval

    requested review from @jessebaker and removed approval

  • Harumi Jang
  • Harumi Jang removed review request for @bnjmnm and @jessebaker

    removed review request for @bnjmnm and @jessebaker

  • Harumi Jang added 8 commits

    added 8 commits

    • 8a6c893c...a8fa36d9 - 2 commits from branch project:0.x
    • 61fc6616 - Close submenu onDrag and reopen onDragEnd and add onClick for submenu
    • 66ef0499 - Add dependency to useCallback
    • 5ab0d22d - Use variable for menu border color and remove extra pixel of thickness
    • 9e6f1881 - Post-rebase add new container value to new submenu components
    • 2cb199cc - Rename Subtrigger to SubmenuTrigger
    • 23cf1aa2 - Close menu on drag by passing in setState to child component

    Compare with previous version

  • Harumi Jang added 1 commit

    added 1 commit

    • 18598103 - Add back subtrigger to dictionary

    Compare with previous version

  • Harumi Jang changed title from #3458617: Close submenu onDrag and reopen onDragEnd and add onClick for submenu to #3458617: Close submenu on drag in primary menu

    changed title from #3458617: Close submenu onDrag and reopen onDragEnd and add onClick for submenu to #3458617: Close submenu on drag in primary menu

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading