Skip to content
Snippets Groups Projects

#3509592 Attempted fixes for test flake

3 unresolved threads

Closes #3509592

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
60 61 // to an ever-increasing iFrame height!
61 62 const elements: NodeListOf<HTMLElement> =
62 63 iframeHTML.querySelectorAll('*');
63 elements.forEach((element: HTMLElement) => {
64 if (element.style.height.endsWith('vh')) {
64 elements.forEach((element) => {
65 if (
66 element instanceof HTMLElement &&
67 element.style.height.endsWith('vh')
  • 71 75
    72 76 resizeIframe();
    73 77 }
    78 };
    79
    80 // Assign the load event listener
    81 iframe.addEventListener('load', handleLoad);
    82
    83 // Check if the iFrame is already loaded
    84 if (iframe.contentDocument?.readyState === 'complete') {
    85 handleLoad();
    • Comment on lines +80 to +85

      Hopefully wrapping the height calculation in a load event but also explicitly calling handleLoad if the document is already by the time we get here makes this more robust and prevents the 'cannot read property 'style' of undefined.

    • Please register or sign in to reply
  • 212 212 force: true,
    213 213 scrollBehavior: false,
    214 214 });
    215 cy.waitForComponentNotInPreview('Image');
  • Passed first time https://git.drupalcode.org/project/experience_builder/-/jobs/4513124 - re-running a few times to see if it was just a fluke

  • This has passed 4 times in a row now. Quietly confident.

  • Jesse Baker marked this merge request as ready

    marked this merge request as ready

  • Wim Leers added 4 commits

    added 4 commits

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading