Resolve #3455728 "ComponentTreeStructure to use a Real tree instead of list"
Closes #3455728
Merge request reports
Activity
Filter activity
added 1 commit
- 6a6bd2c1 - Fix defualt field test values so EndToEndDemoIntegrationTest will pass
- Resolved by Ted Bowman
- Resolved by Ted Bowman
added 1 commit
- 76ccfe6d - kernel test ComponentTreeStructureTest not needed because of new unit test
requested review from @larowlan
Yes, will do next week @lauriii
- Resolved by Ted Bowman
- Resolved by Wim Leers
- Resolved by Ted Bowman
- Resolved by Ted Bowman
!67 (diffs, comment 336720) + !67 (comment 336721) both suggest that this also needs validation logic.
We need to add a validation constraint for
ComponentTreeStructure
. Note that [#3456024] is not overlapping with this: that is about validating theComponentPropsValues
_for a givenComponentTreeStructure
. But long before we get to that point, we need to ensure that at least the tree structure itself is valid (independent from the values for the props of the components in that tree, which is what [#3456024] is about).That validation constraint should validate that:
- the root UUID is present
- any top-level UUID appears as a UUID in a parent branch/tree
assigned to @tedbow
added 1 commit
- 13e3ea0e - update ComponentTreeStructure to not store as actual tree, fix unit test
added 3 commits
added 14 commits
-
f8d31b4f...660fbc41 - 13 commits from branch
project:0.x
- 8c0f2ef7 - Merge branch '0.x' into 3455728-real-tree
-
f8d31b4f...660fbc41 - 13 commits from branch
- Resolved by Ted Bowman
Please register or sign in to reply