Skip to content
Snippets Groups Projects

Resolve #3455728 "ComponentTreeStructure to use a Real tree instead of list"

Merged Ted Bowman requested to merge issue/experience_builder-3455728:3455728-real-tree into 0.x

Closes #3455728

Merge request reports

Code Quality is loading
Test summary results are being parsed

Merged by Wim LeersWim Leers 7 months ago (Jul 12, 2024 11:51am UTC)

Loading

Pipeline #222647 passed

Pipeline passed for a1410b6f on 0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ted Bowman
  • Ted Bowman added 1 commit

    added 1 commit

    • 76ccfe6d - kernel test ComponentTreeStructureTest not needed because of new unit test

    Compare with previous version

  • Lauri Timmanee requested review from @larowlan

    requested review from @larowlan

  • @larowlan is this something you could review while @wimleers is out? :fingers_crossed:

  • Yes, will do next week @lauriii

  • Wim Leers
  • Wim Leers
  • Wim Leers
    • Resolved by Ted Bowman

      !67 (diffs, comment 336720) + !67 (comment 336721) both suggest that this also needs validation logic.

      We need to add a validation constraint for ComponentTreeStructure. Note that [#3456024] is not overlapping with this: that is about validating the ComponentPropsValues _for a given ComponentTreeStructure. But long before we get to that point, we need to ensure that at least the tree structure itself is valid (independent from the values for the props of the components in that tree, which is what [#3456024] is about).

      That validation constraint should validate that:

      • the root UUID is present
      • any top-level UUID appears as a UUID in a parent branch/tree
  • assigned to @tedbow

  • Ted Bowman added 1 commit

    added 1 commit

    • 13e3ea0e - update ComponentTreeStructure to not store as actual tree, fix unit test

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • a5d4f3d4 - throw exception for now to fix tests

    Compare with previous version

  • Ted Bowman added 3 commits

    added 3 commits

    Compare with previous version

  • Ted Bowman added 14 commits

    added 14 commits

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading