Skip to content
Snippets Groups Projects

Resolve #3502819 "Connect new page"

All threads resolved!

Closes #3502819

Merge request reports

Test summary results are being parsed

Merged by Matt GlamanMatt Glaman 2 weeks ago (Jan 30, 2025 8:41pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    I'm not sure if this is the best. But putting it for review. I feel like there is too much going on in PageInfo now and there could be a "NewButton" component. But I couldn't think of a way to keep it composable and in Storybook without tying everything to Redux Toolkit

  • Matt Glaman marked this merge request as ready

    marked this merge request as ready

  • Matt Glaman added 1 commit

    added 1 commit

    Compare with previous version

  • Matt Glaman resolved all threads

    resolved all threads

  • Lee Rowlands
  • Lee Rowlands
  • Lee Rowlands
  • Lauri Timmanee requested review from @jessebaker

    requested review from @jessebaker

  • Matt Glaman added 1 commit

    added 1 commit

    • 4fb02a74 - add setEditorEntity to consolidate logic

    Compare with previous version

  • Matt Glaman added 4 commits

    added 4 commits

    Compare with previous version

  • Matt Glaman added 1 commit

    added 1 commit

    • 24155e7d - add entityType to contentCreateApi

    Compare with previous version

  • Matt Glaman added 1 commit

    added 1 commit

    Compare with previous version

  • Matt Glaman added 6 commits

    added 6 commits

    Compare with previous version

  • Matt Glaman resolved all threads

    resolved all threads

  • Matt Glaman requested review from @larowlan

    requested review from @larowlan

  • Matt Glaman added 4 commits

    added 4 commits

    Compare with previous version

  • Lee Rowlands approved this merge request

    approved this merge request

  • merged

  • :face_palm: I had a stale version of this tab opened from yesterday and just reviewed it not realising it was already approved. So, uh, good job! I also approve of this!

  • Please register or sign in to reply
    Loading