Skip to content
Snippets Groups Projects

Issue #3478565 Just testing if null target has test coverage

Closed Issue #3478565 Just testing if null target has test coverage
1 unresolved thread
1 unresolved thread
1 file
+ 2
1
Compare changes
  • Side-by-side
  • Inline
@@ -32,7 +32,8 @@ final class Evaluator {
// Entity is optional for reference fields: the reference may point to
// something or not.
if ($expr instanceof ReferenceFieldPropExpression) {
return NULL;
// ℹ️ Just commented this out to see if we actually yest this?
// return NULL;
    • Comment on lines +35 to +36
      Author Maintainer

      This affects the other merge. I just want to check if we actually test this logic anywhere. The tests pass so I don't think we do.

      I think the problem is here that in media_library_storage_prop_shape_alter() we set src to use ReferenceFieldPropExpression which because of the code above it does not error out when no image is found. But then other sub properties like alt are not allowed to be null so then throw the OutOfRangeException below this.

Please register or sign in to reply
}
throw new \OutOfRangeException('No data provided to evaluate expression ' . (string) $expr);
}
Loading