Skip to content
Snippets Groups Projects

Resolve #3478565 "Autosave entity revision"

Closes #3478565

Merge request reports

Code Quality is loading
Test summary results are being parsed

Merged by Wim LeersWim Leers 5 months ago (Nov 21, 2024 2:11pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ted Bowman
  • Ted Bowman
  • Ted Bowman
  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • d749d53d - handle the case when the file name has been changed in the uri

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 30 commits

    added 30 commits

    Compare with previous version

  • Ted Bowman added 3 commits

    added 3 commits

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 3 commits

    added 3 commits

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • 86a2c0fd - try to fix json message assert

    Compare with previous version

  • Ted Bowman added 5 commits

    added 5 commits

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • bcc074bb - cast response body to string

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 6 commits

    added 6 commits

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 6 commits

    added 6 commits

    • 050d00d6 - change test to use heading element
    • 967d7b8b - refactor test to make easier to send different invalid json
    • bcada3dc - first attempt to validate field item
    • c5ac47ac - add test case with invalid props
    • 3822d8db - call validate on entity not field item
    • ec99b67a - phpcs

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 3 commits

    added 3 commits

    • cd75fb24 - add todo about target id from client
    • c89ce2c4 - better var names
    • a3d23466 - need to sort test props by keys

    Compare with previous version

  • Ted Bowman
  • Dave Long
  • Ted Bowman added 2 commits

    added 2 commits

    • fde13386 - do not return on first invalid props
    • 86f3d499 - add instance uuid to error message

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • 2277edfc - use assertEqualsCanonicalizing instead of custom function

    Compare with previous version

  • assigned to @tedbow

  • Travis Carden
  • Ted Bowman added 1 commit

    added 1 commit

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • a6c76ae5 - Revert "use assertEqualsCanonicalizing instead of custom function"

    Compare with previous version

  • Ted Bowman added 1 commit

    added 1 commit

    • b94dca84 - add todo to fix assertEqualsCanonicalizing problem

    Compare with previous version

  • Travis Carden approved this merge request

    approved this merge request

  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Wim Leers
    • Resolved by Wim Leers

      Very much on the right track, but I think in the current state it'll be hard to evolve.

      I left a bunch of suggestions that IMHO make this more approachable, and make it easier to iterate on in the future.

      WDYT, @tedbow ?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading