Skip to content
Snippets Groups Projects

#3469672: Scale the not-to-be-scaled XB annotations by the inverse of current scale

The XB annotations and labels should not change size when zooming. We've tried different approaches before — this MR implements @effulgentsia's idea of scaling the not-to-be-scaled components by the inverse amount, so that when the ancestor <div> is scaled, it cancels out.

Besides doing that, we also need to factor in the current zoom level when calculating the dimensions of the outline.

Merge request reports

Approved by
Test summary results are being parsed
Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bálint Kléri requested changes

    requested changes

  • utkarsh_33 added 3 commits

    added 3 commits

    • 234d8c2f - Modified xb-canvas test to make it easy to understand how we calculated stuff
    • 878ce34b - Removed min-width property
    • 36ef4c95 - Resturctured test to use cy.as() and cy.get(@alias) instead of this variable

    Compare with previous version

  • utkarsh_33 resolved all threads

    resolved all threads

  • utkarsh_33 added 1 commit

    added 1 commit

    • 2c4e4d0c - Exclude the add section/component button form transform

    Compare with previous version

  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Should we also have a test for <100% zoom?

    And I'm confused why we're testing the outline and annotation dimensions independently — the very point of this issue is that they should both behave correctly (and in different ways) when changing the zoom level.

  • Wim Leers requested changes

    requested changes

  • utkarsh_33 added 1 commit

    added 1 commit

    • 134915a1 - Moved the tests to different file and also added tests for zoom out

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading