#3471108: Unable to scroll component props form
Reworking the layout inside the contextual panel to make the content under the tabs scrollable.
Merge request reports
Activity
requested review from @bnjmnm
- Resolved by Bálint Kléri
added 6 commits
-
2bc420ef...c3443861 - 5 commits from branch
project:0.x
- a687b259 - Merge branch '0.x' into 3471108-unable-to-scroll-component-props-form
-
2bc420ef...c3443861 - 5 commits from branch
- Resolved by Bálint Kléri
I have a concern here that by switching from the Radix Scroll Area component, the scroll bars here are going to look bad on Windows and also don't look great when you enable "Always show scroll bars" on Mac. I don't have access to a Windows machine to verify my concern though.
I don't think we HAVE to use the Scroll Area component though, we can just use CSS to style the scroll bars https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scrollbars_styling
Thoughts?
This is a really good point! I would like to go back and spend some time with Radix Theme's Scroll Area again, because it seems that the Radix primitive (also called Scroll Area) should be able to do this via CSS, so I may have missed something. If not, we can try and write our own component based on the Radix primitive. I'll take a stab at this, and if it turns out to take more, I'll open a new issue for it.
added 84 commits
-
a687b259...3352d8a1 - 83 commits from branch
project:0.x
- 37fc00d6 - Merge branch '0.x' into 3471108-unable-to-scroll-component-props-form
-
a687b259...3352d8a1 - 83 commits from branch
mentioned in merge request !258 (closed)
added 2 commits
added 2 commits
307 `${prop} (${selector}) should be '${newValues[prop]}'`, 308 ).to.equal(newValues[prop]); 309 }); 310 // Special check for ctaHref as it is an attribute value. 311 expect( 312 hero.querySelector(heroSelectors.cta1).getAttribute('formaction'), 313 ).to.equal(newValues.cta1href); 314 }, 292 cy.waitForElementContentInIframe(heroSelectors.heading, newValues.heading); 293 cy.waitForElementContentInIframe( 294 heroSelectors.subheading, 295 newValues.subheading, 315 296 ); 297 cy.waitForElementContentInIframe(heroSelectors.cta1, newValues.cta1); 298 cy.waitForElementContentInIframe(heroSelectors.cta2, newValues.cta2); 316 299 }); - Comment on lines -300 to 316
Somehow the markup changes in the sidebar surfaced a race condition issue with asserting content in the preview iframe. Even by using
cy.previewReady()
, this code easily picked up the older iframe. Switching tocy.waitForElementContentInIframe
fixes it, which we already know is robust enough fromprop-types.cy.js
.
requested review from @jessebaker and removed review request for @bnjmnm
added 1 commit
- 49fae48c - Per @jessebaker and @balintbrews: require the `semi-coupled theme engine`...
added 5 commits
-
49fae48c...2f84d78e - 4 commits from branch
project:0.x
- 38008a3a - Merge remote-tracking branch 'origin/0.x' into 3471108-unable-to-scroll-component-props-form
-
49fae48c...2f84d78e - 4 commits from branch
mentioned in merge request !358 (merged)