Skip to content
Snippets Groups Projects

#3471108: Unable to scroll component props form

1 unresolved thread

Reworking the layout inside the contextual panel to make the content under the tabs scrollable.

xb-component-props-form-scrolling-2

Edited by Bálint Kléri

Merge request reports

Approval is optional
Test summary results are being parsed

Merged by Wim LeersWim Leers 4 months ago (Oct 14, 2024 3:36pm UTC)

Merge details

  • Changes merged into with 3e33fe96.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bálint Kléri marked this merge request as ready

    marked this merge request as ready

  • Bálint Kléri added 6 commits

    added 6 commits

    • 2bc420ef...c3443861 - 5 commits from branch project:0.x
    • a687b259 - Merge branch '0.x' into 3471108-unable-to-scroll-component-props-form

    Compare with previous version

  • Bálint Kléri resolved all threads

    resolved all threads

  • This is a really good point! I would like to go back and spend some time with Radix Theme's Scroll Area again, because it seems that the Radix primitive (also called Scroll Area) should be able to do this via CSS, so I may have missed something. If not, we can try and write our own component based on the Radix primitive. I'll take a stab at this, and if it turns out to take more, I'll open a new issue for it.

  • Bálint Kléri added 84 commits

    added 84 commits

    • a687b259...3352d8a1 - 83 commits from branch project:0.x
    • 37fc00d6 - Merge branch '0.x' into 3471108-unable-to-scroll-component-props-form

    Compare with previous version

  • Bálint Kléri mentioned in merge request !258 (closed)

    mentioned in merge request !258 (closed)

  • added 1 commit

    • b54c78f2 - Remove close and resize icons

    Compare with previous version

  • added 1 commit

    • ca4ea0b8 - Remove close and resize icons

    Compare with previous version

  • added 1 commit

    • f5ed8e16 - Remove close and resize icons

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Bálint Kléri added 2 commits

    added 2 commits

    • f2211b95 - Fix stylelint issue
    • 806e7815 - Remove testing steps that close the right sidebar

    Compare with previous version

  • Bálint Kléri changed the description

    changed the description

  • Bálint Kléri resolved all threads

    resolved all threads

  • Jesse Baker added 1 commit

    added 1 commit

    • 3d9885a0 - Adjust scrollbar position of sidebar

    Compare with previous version

  • Bálint Kléri added 2 commits

    added 2 commits

    • 577edbbf - Remove irrelevant test steps
    • 6582b2b1 - Fix race condition with preview in test

    Compare with previous version

  • 307 `${prop} (${selector}) should be '${newValues[prop]}'`,
    308 ).to.equal(newValues[prop]);
    309 });
    310 // Special check for ctaHref as it is an attribute value.
    311 expect(
    312 hero.querySelector(heroSelectors.cta1).getAttribute('formaction'),
    313 ).to.equal(newValues.cta1href);
    314 },
    292 cy.waitForElementContentInIframe(heroSelectors.heading, newValues.heading);
    293 cy.waitForElementContentInIframe(
    294 heroSelectors.subheading,
    295 newValues.subheading,
    315 296 );
    297 cy.waitForElementContentInIframe(heroSelectors.cta1, newValues.cta1);
    298 cy.waitForElementContentInIframe(heroSelectors.cta2, newValues.cta2);
    316 299 });
    • Comment on lines -300 to 316

      Somehow the markup changes in the sidebar surfaced a race condition issue with asserting content in the preview iframe. Even by using cy.previewReady(), this code easily picked up the older iframe. Switching to cy.waitForElementContentInIframe fixes it, which we already know is robust enough from prop-types.cy.js.

    • Please register or sign in to reply
  • Bálint Kléri requested review from @jessebaker and removed review request for @bnjmnm

    requested review from @jessebaker and removed review request for @bnjmnm

  • Jesse Baker approved this merge request

    approved this merge request

  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers added 5 commits

    added 5 commits

    • 49fae48c...2f84d78e - 4 commits from branch project:0.x
    • 38008a3a - Merge remote-tracking branch 'origin/0.x' into 3471108-unable-to-scroll-component-props-form

    Compare with previous version

  • merged

  • Bálint Kléri mentioned in merge request !358 (merged)

    mentioned in merge request !358 (merged)

  • Please register or sign in to reply
    Loading