#3446722: Introduce an example set of representative SDC components; transition from "component list" to "component tree"
Merge request reports
Activity
added 1 commit
- 13f6d103 - Add example SDC components in new submodule.
mentioned in merge request !15 (merged)
added 103 commits
-
f3d44485...2369adc0 - 95 commits from branch
project:0.x - f18cff74 - default design system start
- 210e4709 - slots work, and addressed a props issue that has me wondering how they worked previously
- 9737ce9b - slot support added
- ee988675 - Add example SDC components in new submodule.
- 35a0f5a5 - Add example SDC components in new submodule.
- 32ac83ef - Work-around: declare two slots for `side_by_side`.
- f2bb4a4d - Fix: make `label` an optional prop for `shoe_icon`.
- 428b7a5c - Fix the type on two column width.
Toggle commit list-
f3d44485...2369adc0 - 95 commits from branch
added 5 commits
Toggle commit list
9 background: 10 type: string 11 title: Background color 12 description: The background color. 13 enum: 14 - '' 15 - primary 16 - secondary 17 - white 18 examples: ['', primary, secondary, white] 19 media_position: 20 type: string 21 title: Media Position 22 description: The position of the media components. 23 enum: 24 - left changed this line in version 13 of the diff
+1, but let's do that in a follow-up issue. This is just meant to serve as an example for the structure that XB needs to support, the implementation details of these components are irrelevant.
Would you mind creating such a follow-up, @finnsky?
1 [data-component-id="experience_builder_example_components:side_by_side"] { 2 -
Probably no need to increase CSS specificity here? Or at least use is with https://developer.mozilla.org/en-US/docs/Web/CSS/:where
changed this line in version 40 of the diff
1 '$schema': 'https://git.drupalcode.org/project/sdc/-/raw/1.x/src/metadata.schema.json' changed this line in version 75 of the diff
1 '$schema': 'https://git.drupalcode.org/project/sdc/-/raw/1.x/src/metadata.schema.json' -
I would better replace that
One/Two/... Columnsto more universalGridComponent. WIth configurable width and columns amount. With https://developer.mozilla.org/en-US/docs/Web/CSS/grid-auto-columns changed this line in version 75 of the diff
1 '$schema': 'https://git.drupalcode.org/project/sdc/-/raw/1.x/src/metadata.schema.json' -
Will this component ever be used without main
Tabscomponent? I think no. So according to BEM it seems incorrectAn element is always part of a block, and you shouldn't use it separately from the block.
changed this line in version 75 of the diff
1 '$schema': 'https://git.drupalcode.org/project/sdc/-/raw/1.x/src/metadata.schema.json' changed this line in version 75 of the diff
assigned to @wimleers
-
Ready for @wimleers to continue @ctrlADel's work, but while awaiting that, marking this as draft, see https://www.drupal.org/project/experience_builder/issues/3446722#comment-15635735 for context.
