Skip to content
Snippets Groups Projects

Changed the color for text as we are using white background

3 unresolved threads

Closes #3465140

Merge request reports

Merged results pipeline #240538 skipped

Merged results pipeline skipped for 6180c8b1

Approval is optional

Merged by Ben MullinsBen Mullins 6 months ago (Aug 1, 2024 1:02pm UTC)

Merge details

  • Changes merged into with c8eb44a3.
  • Did not delete the source branch.

Pipeline #241314 passed

Pipeline passed for c8eb44a3 on 0.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
157 157 const expectedLabels = ['heading', 'subheading', 'cta1', 'cta1href', 'cta2'];
158 158 $form.find('label').each((index, label) => {
159 159 expect(label.textContent).to.equal(expectedLabels[index])
160 // Ensures that each label is visible.
161 expect(label).to.be.visible
  • Color is not taken into account with visibility assertions - this would not catch the issue reported here.

    The a11y tests do check for this sort of thing, but were not caught - I know that contrast problems with the <h4> inside this panel were caught by the a11y tests. It is possible the axe tests need additional config to test elements inside fragments or custom tags. If this is not easily addressed here a followup should be created.

  • Author Contributor

    Can we keep this assertion?

  • Do not keep this. There are other tests already there that implicitly check for visibility in the manner that this assertion does.

  • utkarsh_33 changed this line in version 4 of the diff

    changed this line in version 4 of the diff

  • Please register or sign in to reply
  • 1 1 .componentFieldForm {
    2 color: white;
    2 color: black;
  • utkarsh_33 added 2 commits

    added 2 commits

    Compare with previous version

  • 30 29 formId: attributes['data-drupal-selector'] || '',
    31 30 });
    32 31 const existingClass = attributes.class || '';
    33 attributes.class = `${existingClass} ${styles.componentFieldForm}`;
    32 attributes.class = `${existingClass}`;
  • utkarsh_33 added 2 commits

    added 2 commits

    • 83315423 - Removed unwanted assertion in tests
    • 81d94eec - removed attribute class

    Compare with previous version

  • Ben Mullins added 7 commits

    added 7 commits

    • c5212d1a - 1 commit from branch project:0.x
    • e08a3535 - Changed the color for text as we are using white background
    • e34a54a5 - Added assertion for visibility
    • 03db2e16 - removed style completely
    • ed3a76a5 - Removed file
    • 9a4d1fc9 - Removed unwanted assertion in tests
    • 3ee2eb57 - removed attribute class

    Compare with previous version

  • Ben Mullins approved this merge request

    approved this merge request

  • merged

  • Please register or sign in to reply
    Loading