Changed the color for text as we are using white background
3 unresolved threads
Closes #3465140
Merge request reports
Activity
Filter activity
assigned to @Utkarsh_33
requested review from @bnjmnm
157 157 const expectedLabels = ['heading', 'subheading', 'cta1', 'cta1href', 'cta2']; 158 158 $form.find('label').each((index, label) => { 159 159 expect(label.textContent).to.equal(expectedLabels[index]) 160 // Ensures that each label is visible. 161 expect(label).to.be.visible Color is not taken into account with visibility assertions - this would not catch the issue reported here.
The a11y tests do check for this sort of thing, but were not caught - I know that contrast problems with the
<h4>
inside this panel were caught by the a11y tests. It is possible the axe tests need additional config to test elements inside fragments or custom tags. If this is not easily addressed here a followup should be created.changed this line in version 4 of the diff
1 1 .componentFieldForm { 2 color: white; 2 color: black; changed this line in version 3 of the diff
added 2 commits
30 29 formId: attributes['data-drupal-selector'] || '', 31 30 }); 32 31 const existingClass = attributes.class || ''; 33 attributes.class = `${existingClass} ${styles.componentFieldForm}`; 32 attributes.class = `${existingClass}`; changed this line in version 4 of the diff
added 2 commits
added 7 commits
Toggle commit list
Please register or sign in to reply