Skip to content
Snippets Groups Projects

Actual e2e testing

Actual e2e testing

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • 07a0ac38 - what is so different about the iframe on drupalci

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • 86cb5c4d - see if waitForElementInIframe just cant hang

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • 20d7c390 - DEBUG so xb-components is not loading. Is there ANY chance removing the node 1...

    Compare with previous version

  • Ben Mullins added 4 commits

    added 4 commits

    • 20d7c390...cf4bebb7 - 3 commits from branch project:0.x
    • 2508462a - Merge remote-tracking branch 'origin' into e2e-without-mocks-3461435

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • b396e7a6 - log request to components endpoint

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • e83393a1 - make the endpoints support a different webroot... again

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • db37f1e8 - the one way I can figure out how to base url this

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • ba971dd3 - also the dummy form uses base url

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • a52bd0aa - unit tests don't bring in drupalSettings, the current solution is hackier than...

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    • 881f4fa8 - node 1 is only in test setup

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins
  • Ben Mullins
  • Ben Mullins
  • Ben Mullins
  • Ben Mullins
  • Wim Leers
  • Wim Leers added 1 commit

    added 1 commit

    Compare with previous version

  • Wim Leers
  • Wim Leers
  • Wim Leers
  • Wim Leers requested changes

    requested changes

  • assigned to @bnjmnm

  • Wim Leers requested review from @wimleers

    requested review from @wimleers

  • Wim Leers requested review from @jessebaker

    requested review from @jessebaker

  • Approved - I left a comment but I don't think it needs actioning as part of this MR

  • Jesse Baker approved this merge request

    approved this merge request

  • Ben Mullins added 2 commits

    added 2 commits

    • c7364429 - function docs
    • 797085a3 - Merge branch 'e2e-without-mocks-3461435' of...

    Compare with previous version

  • Ben Mullins added 2 commits

    added 2 commits

    Compare with previous version

  • Ben Mullins added 1 commit

    added 1 commit

    Compare with previous version

  • Ben Mullins resolved all threads

    resolved all threads

  • 2 2 import { createApi, fetchBaseQuery } from '@reduxjs/toolkit/query/react';
    3 3
    4 4 // Define a service using a base URL and expected endpoints
    5 const { drupalSettings } = window as any;
    6
    5 7 export const dummyPropsFormApi = createApi({
    6 8 reducerPath: 'dummyPropsFormApi',
    7 9 baseQuery: fetchBaseQuery({
    8 baseUrl: '/xb-field-form',
    10 baseUrl: `${drupalSettings?.path?.baseUrl || '/'}xb-field-form`,
    • Comment on lines +5 to +10

      I'm surprised this is repeating logic from main.tsx, but AFAICT that is because dummyPropsFormApi is not yet using baseQuery and hence not using configurationSlice/appConfiguration as introduced by #3452582. I suspect that is because there is no mock API for /xb-field-form.

      However, this is a pre-existing "problem" introduced by #3452512, that it makes no sense at all to block this on improving that.

      All the dummyPropsForm functionality will evolve anyway, starting with #3461422. What matters much more, is the fact that this will add much-needed test coverage spanning both client and server :smile: :tada:

    • Please register or sign in to reply
  • 34 34 ])
    35 35 ->save();
    36 36 }
    37
    38 // Cache flush ensures the contextual form works.
    39 drupal_flush_all_caches();
  • Wim Leers approved this merge request

    approved this merge request

  • merged

  • Please register or sign in to reply
    Loading