Actual e2e testing
Actual e2e testing
Merge request reports
Activity
added 1 commit
- de538ab1 - update assertions to be a little easier to diagnose
added 1 commit
- 03d7ec3c - debug why iframe contents not showing up in Gitlab
- Resolved by Wim Leers
added 1 commit
- 07a0ac38 - what is so different about the iframe on drupalci
added 1 commit
- 86cb5c4d - see if waitForElementInIframe just cant hang
added 1 commit
- 20d7c390 - DEBUG so xb-components is not loading. Is there ANY chance removing the node 1...
added 4 commits
-
20d7c390...cf4bebb7 - 3 commits from branch
project:0.x
- 2508462a - Merge remote-tracking branch 'origin' into e2e-without-mocks-3461435
-
20d7c390...cf4bebb7 - 3 commits from branch
added 1 commit
- e83393a1 - make the endpoints support a different webroot... again
added 1 commit
- db37f1e8 - the one way I can figure out how to base url this
added 1 commit
- a52bd0aa - unit tests don't bring in drupalSettings, the current solution is hackier than...
- Resolved by Wim Leers
- Resolved by Ben Mullins
- Resolved by Ben Mullins
- Resolved by Ben Mullins
- Resolved by Wim Leers
- Resolved by Wim Leers
added 1 commit
- Resolved by Ben Mullins
- Resolved by Ben Mullins
- Resolved by Ben Mullins
assigned to @bnjmnm
requested review from @wimleers
requested review from @jessebaker
added 2 commits
added 2 commits
2 2 import { createApi, fetchBaseQuery } from '@reduxjs/toolkit/query/react'; 3 3 4 4 // Define a service using a base URL and expected endpoints 5 const { drupalSettings } = window as any; 6 5 7 export const dummyPropsFormApi = createApi({ 6 8 reducerPath: 'dummyPropsFormApi', 7 9 baseQuery: fetchBaseQuery({ 8 baseUrl: '/xb-field-form', 10 baseUrl: `${drupalSettings?.path?.baseUrl || '/'}xb-field-form`, - Comment on lines +5 to +10
I'm surprised this is repeating logic from
main.tsx
, but AFAICT that is becausedummyPropsFormApi
is not yet usingbaseQuery
and hence not usingconfigurationSlice
/appConfiguration
as introduced by #3452582. I suspect that is because there is no mock API for/xb-field-form
.However, this is a pre-existing "problem" introduced by #3452512, that it makes no sense at all to block this on improving that.
All the
dummyPropsForm
functionality will evolve anyway, starting with #3461422. What matters much more, is the fact that this will add much-needed test coverage spanning both client and server