Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
E
etracker
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
etracker
Commits
7491f991
Commit
7491f991
authored
4 months ago
by
Sven Schüring
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3238489
by sunlix, design.er: Uncaught TypeError: Cannot read properties of null
parent
2228276f
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!45
Decouple etracker.js from vendor library definition
Pipeline
#303969
passed with warnings
4 months ago
Stage: build
Stage: validate
Stage: test
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
etracker.module
+8
-8
8 additions, 8 deletions
etracker.module
with
8 additions
and
8 deletions
etracker.module
+
8
−
8
View file @
7491f991
...
...
@@ -64,18 +64,17 @@ function etracker_library_info_build(): array {
||
$eventTracking
[
'track_system_messages'
];
if
(
$isEventTrackingEnabled
)
{
$libraries
[
$libraryName
][
'js'
]
+=
[
'js/etracker.js'
=>
[
'attributes'
=>
[
'id'
=>
'etracker_script'
,
'defer'
=>
TRUE
,
$libraries
[
'event_tracking'
]
=
[
'js'
=>
[
'js/etracker.js'
=>
[
'attributes'
=>
[
'id'
=>
'etracker_script'
,
],
],
],
];
$libraries
[
$libraryName
]
+=
[
'dependencies'
=>
[
'core/drupal'
,
'core/drupalSettings'
,
Constants
::
ETRACKER_FULL_LIBRARY_NAME
,
],
];
}
...
...
@@ -181,6 +180,7 @@ function etracker_page_attachments_alter(array &$attachments): void {
}
$attachments
[
'#attached'
][
'library'
][]
=
Constants
::
ETRACKER_FULL_LIBRARY_NAME
;
$attachments
[
'#attached'
][
'library'
][]
=
'etracker/event_tracking'
;
$attachments
[
'#attached'
][
'drupalSettings'
][
'etracker'
]
=
$script_settings
;
$request
=
Drupal
::
request
();
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment