Skip to content
Snippets Groups Projects

Close #3484735 Move toolbar integration into separate module

Close #3484735 Move toolbar integration into separate module
issue/environment_indicator-3484735:3484735-move-toolbar-integration into 4.x
All threads resolved!
Closed
Chris Greenrequested to merge
issue/environment_indicator-3484735:3484735-move-toolbar-integration into 4.x
All threads resolved!

Closes #3484735

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 1 commit

    added 1 commit

    • 8965a8d2 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green added 4 commits

    added 4 commits

    Compare with previous version

  • Chris Green added 5 commits

    added 5 commits

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green added 5 commits

    added 5 commits

    Compare with previous version

  • Chris Green @trackleft2 started a thread on an old version of the diff
    • css/environment_indicator.css
    92 border-top: var(--environment-indicator-border-width) solid;
    93 border-bottom: 0;
    94 }
    95
    96 .gin--horizontal-toolbar .gin-secondary-toolbar {
    97 margin-top: var(--environment-indicator-border-width);
    98 }
    99
    100 .gin--vertical-toolbar .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
    101 margin-inline-start: calc(var(--gin-toolbar-width-collapsed, var(--ginToolbarWidthCollapsed)) - 4px);
    102 }
    103
    104 .gin--vertical-toolbar[data-toolbar-menu="open"] .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
    105 margin-inline-start: calc(var(--gin-toolbar-width, var(--ginToolbarWidth)) - 4px);
    55 background-color: #edede0;
    56 font-size: 1em;
  • Chris Green added 1 commit

    added 1 commit

    • ed76ef56 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green @trackleft2 started a thread on an old version of the diff
    • css/environment_indicator.css
    91 .gin--horizontal-toolbar #toolbar-item-administration-tray {
    92 border-top: var(--environment-indicator-border-width) solid;
    93 border-bottom: 0;
    94 }
    95
    96 .gin--horizontal-toolbar .gin-secondary-toolbar {
    97 margin-top: var(--environment-indicator-border-width);
    98 }
    99
    100 .gin--vertical-toolbar .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
    101 margin-inline-start: calc(var(--gin-toolbar-width-collapsed, var(--ginToolbarWidthCollapsed)) - 4px);
    102 }
    103
    104 .gin--vertical-toolbar[data-toolbar-menu="open"] .toolbar-menu-administration > .toolbar-menu > .menu-item .toolbar-menu {
    105 margin-inline-start: calc(var(--gin-toolbar-width, var(--ginToolbarWidth)) - 4px);
    55 background-color: #edede0;
  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    • 2ede0097 - Edit environment_indicator.css

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green @trackleft2 started a thread on an old version of the diff
    • environment_indicator.module
    135 189 'style' => 'cursor: pointer',
    136 190 'title' => t('Show the environment switcher.'),
    137 191 ];
    192 $environment_indicator_switcher_cache_tags = \Drupal::entityTypeManager()->getDefinition('environment_indicator')->getListCacheTags();
  • Chris Green added 1 commit

    added 1 commit

    • 96b7a1e6 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green added 2 commits

    added 2 commits

    • 89e212b4 - Fix PHPStan error
    • 029e23f4 - Merge branch '3484735-move-toolbar-integration' of...

    Compare with previous version

  • Chris Green marked this merge request as ready

    marked this merge request as ready

  • Chris Green added 2 commits

    added 2 commits

    • 91751365 - 1 commit from branch project:4.x
    • 9b5d9bb9 - Merge branch environment_indicator:4.x into 3484735-move-toolbar-integration

    Compare with previous version

  • Chris Green added 3 commits

    added 3 commits

    Compare with previous version

  • Chris Green added 3 commits

    added 3 commits

    • 8b64c174...b8bab43e - 2 commits from branch project:4.x
    • fc9f2281 - Merge branch environment_indicator:4.x into 3484735-move-toolbar-integration

    Compare with previous version

  • Chris Green added 3 commits

    added 3 commits

    • fc9f2281...21ccf330 - 2 commits from branch project:4.x
    • be2931ea - Merge branch environment_indicator:4.x into 3484735-move-toolbar-integration

    Compare with previous version

  • Chris Green added 2 commits

    added 2 commits

    • 2f3885aa - 1 commit from branch project:4.x
    • 92281c17 - Merge branch environment_indicator:4.x into 3484735-move-toolbar-integration

    Compare with previous version

  • Chris Green added 4 commits

    added 4 commits

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • T
    Chris Green @trackleft2
    Author Developer

    Superceded by !102 (merged)

  • Chris Green closed

    closed

    • Please register or sign in to reply