Skip to content
Snippets Groups Projects

Issue #3526658 Create new EnvironmentIndicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags

Issue #3526658 Create new EnvironmentIndicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags
All threads resolved!

Closes #3526658

Merge request reports

Merge train pipeline #512798 passed

Merge train pipeline passed for 2c31ecbd

Approval is optional
Code Quality is loading
Test summary results are being parsed

Merged by Chris GreenChris Green 1 month ago (Jun 3, 2025 4:07am UTC)

Merge details

  • Changes merged into with 2c31ecbd.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Green added 1 commit
  • Chris Green added 1 commit
  • Chris Green marked this merge request as draft

    marked this merge request as draft

  • Chris Green changed title from Issue #3526658 Extract Indicator Context logic from ToolbarHandler into new Indicator service to Draft: Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods `getTitle`, `getCurrentRelease`, `getVersionIdentifier`, `hasAccessAll`, `hasAccessEnvironment`, `hasAccessActiveEnvironment`
    changed title from Issue #3526658 Extract Indicator Context logic from ToolbarHandler into new Indicator service to Draft: Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods `getTitle`, `getCurrentRelease`, `getVersionIdentifier`, `hasAccessAll`, `hasAccessEnvironment`, `hasAccessActiveEnvironment`
  • Chris Green changed title from Draft: Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods `getTitle`, `getCurrentRelease`, `getVersionIdentifier`, `hasAccessAll`, `hasAccessEnvironment`, `hasAccessActiveEnvironment` to Draft: Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment
    changed title from Draft: Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods `getTitle`, `getCurrentRelease`, `getVersionIdentifier`, `hasAccessAll`, `hasAccessEnvironment`, `hasAccessActiveEnvironment` to Draft: Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment
  • Chris Green added 1 commit

    added 1 commit

    • de67dbe0 - Add in deprecations, a methods back

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    • e870dcdf - Adding in exact inline replacement for the deprecated hasAccessEnvironment() method.

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    • 1a5744d6 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 2 commits

    added 2 commits

    • d5e3b581 - PHPCS
    • 796e79dd - Merge branch '3526658-extract-indicator-context' of...

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    • 0228c2e3 - Hard-code js settings for toolbar in toolbar service.

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    • a1d6ac0d - Update tests and fix permissions

    Compare with previous version

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 1 commit

    added 1 commit

    • cf949c3f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green added 2 commits

    added 2 commits

    • de499780 - Revert Tests
    • 617a9665 - Merge branch '3526658-extract-indicator-context' of...

    Compare with previous version

  • Chris Green marked this merge request as ready

    marked this merge request as ready

  • Chris Green added 1 commit

    added 1 commit

    • 9c6a1dba - Issue #3526658 deprecate methods in ToolbarHandler in preparation for deprecating the service.

    Compare with previous version

  • Chris Green changed title from Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment to Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags
    changed title from Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment to Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags
  • Chris Green added 1 commit

    added 1 commit

    • 4f5eae76 - Ignore deprecations since they are our deprecations.

    Compare with previous version

  • Chris Green changed title from Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags to Issue #3526658 Create new EnvironmentIndicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags
    changed title from Issue #3526658 Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags to Issue #3526658 Create new EnvironmentIndicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags
  • Chris Green added 1 commit

    added 1 commit

    • c7ddec2b - Add new test to ensure empty name means no indicator.

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 1 commit

    added 1 commit

    • 005ce759 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 1 commit

    added 1 commit

    • 5013d3f3 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 1 commit

    added 1 commit

    Compare with previous version

  • Chris Green resolved all threads

    resolved all threads

  • Chris Green added 1 commit

    added 1 commit

    • e87362c0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Chris Green enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Please register or sign in to reply
    Loading