Skip to content
Snippets Groups Projects

First stab.

1 unresolved thread

Closes #3472845

Merge request reports

Members who can merge are allowed to add commits.
Approval is optional
Code Quality is loading
Test summary results are being parsed
Ready to merge by members who can write to the target branch.
  • The source branch is 1 commit behind the target branch.
  • 13 commits and 1 merge commit will be added to .
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
99 * @param \Drupal\Core\Messenger\MessengerInterface $messenger
89 * @param \Drupal\Core\Messenger\MessengerInterface|\Drupal\Core\Database\Connection $messenger
100 90 * The messenger service.
101 91 */
102 public function __construct(EntityTypeManagerInterface $entity_type_manager, EntityFieldManagerInterface $entity_field_manager, DateFormatterInterface $date_formatter, TimeInterface $time, Connection $database, MessengerInterface $messenger) {
92 public function __construct(EntityTypeManagerInterface $entity_type_manager, EntityFieldManagerInterface $entity_field_manager, DateFormatterInterface $date_formatter, TimeInterface $time, $messenger) {
103 93 $this->entityTypeManager = $entity_type_manager;
104 94 $this->entityFieldManager = $entity_field_manager;
105 95 $this->dateFormatter = $date_formatter;
106 96 $this->time = $time;
107 $this->database = $database;
108 97 $this->messenger = $messenger;
98
99 if ($messenger instanceof Connection) {
100 $this->messenger = func_get_arg(5);
101 @trigger_error('Calling ' . __CLASS__ . '::_construct() with the $database argument is deprecated in entity_reference_revisions:1.13 and is removed entity_reference_revisions drupal:2.0. See https://www.drupal.org/node/3472857', E_USER_DEPRECATED);
  • there's an extra " drupal" in there that shouldn't exist.

    I appreciate the BC layer, having a CR for a constructor like this change is IMHO unnecessary, it's going to affect 0.01% of users, if any and the change is obvious. But I also know that phpcs rules require that there is a link, (which I think was not the right call)

  • Please register or sign in to reply
Please register or sign in to reply
Loading