First stab.
1 unresolved thread
Open
requested to merge issue/entity_reference_revisions-3472845:3472845-replace-db--with into 8.x-1.x
1 unresolved thread
Closes #3472845
Merge request reports
Activity
99 * @param \Drupal\Core\Messenger\MessengerInterface $messenger 89 * @param \Drupal\Core\Messenger\MessengerInterface|\Drupal\Core\Database\Connection $messenger 100 90 * The messenger service. 101 91 */ 102 public function __construct(EntityTypeManagerInterface $entity_type_manager, EntityFieldManagerInterface $entity_field_manager, DateFormatterInterface $date_formatter, TimeInterface $time, Connection $database, MessengerInterface $messenger) { 92 public function __construct(EntityTypeManagerInterface $entity_type_manager, EntityFieldManagerInterface $entity_field_manager, DateFormatterInterface $date_formatter, TimeInterface $time, $messenger) { 103 93 $this->entityTypeManager = $entity_type_manager; 104 94 $this->entityFieldManager = $entity_field_manager; 105 95 $this->dateFormatter = $date_formatter; 106 96 $this->time = $time; 107 $this->database = $database; 108 97 $this->messenger = $messenger; 98 99 if ($messenger instanceof Connection) { 100 $this->messenger = func_get_arg(5); 101 @trigger_error('Calling ' . __CLASS__ . '::_construct() with the $database argument is deprecated in entity_reference_revisions:1.13 and is removed entity_reference_revisions drupal:2.0. See https://www.drupal.org/node/3472857', E_USER_DEPRECATED); there's an extra " drupal" in there that shouldn't exist.
I appreciate the BC layer, having a CR for a constructor like this change is IMHO unnecessary, it's going to affect 0.01% of users, if any and the change is obvious. But I also know that phpcs rules require that there is a link, (which I think was not the right call)
Please register or sign in to reply