Skip to content
Snippets Groups Projects

Issue #3157659: Remove check for isAdminRoute

Issue #3157659: Remove check for isAdminRoute
issue/entity_hierarchy-3157659:3157659-allow-breadcrumb-to into 5.x
1 unresolved thread
Open Adam Bramley requested to merge issue/entity_hierarchy-3157659:3157659-allow-breadcrumb-to into 5.x

Closes #3157659

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
modules/entity_hierarchy_breadcrumb/src/HierarchyBasedBreadcrumbBuilder.php
25 25 *
26 26 * @param \Drupal\Core\Entity\EntityFieldManagerInterface $entityFieldManager
27 27 * The entity field manager service.
28 * @param \Drupal\Core\Routing\AdminContext $adminContext
29 * The admin context service.
30 28 * @param \Drupal\entity_hierarchy\Storage\QueryBuilderFactory $queryBuilderFactory
31 29 * Query builder factory.
32 30 */
33 31 public function __construct(
34 32 protected EntityFieldManagerInterface $entityFieldManager,
35 protected AdminContext $adminContext,
  • Adam Bramley
    Adam Bramley @acbramley ·
    Author Contributor

    Not sure if we want to deprecate this instead? That'd involve keeping the param and allowing it to be nullable and then triggering a deprecation if it exists?

  • dpi
    dpi @dpi ·
    Contributor

    So, deprecate til next major?

    Plan would be, set null in services yaml and trigger deprecation if not null in constructor? SGTM

  • Please register or sign in to reply
Please register or sign in to reply