[3623437] Establish clean lint baseline

Ivan Hrynenkorequested to merge
feature/3623437-lint-baseline into 2.x

Drupal.org issue: #3623437

Summary

  • Resolves the existing CSpell, ESLint, PHPCS, PHPStan, and Stylelint findings.
  • Removes empty stylesheet/service files and their unused library declarations.
  • Replaces Drupal 10-deprecated patterns identified by static analysis, including user_role_names() and static service lookups, while preserving existing behaviour.
  • Keeps PHPUnit metadata compatible with Drupal 10's PHPUnit 9 runner.
  • Makes all validation jobs blocking now that the 2.x baseline is clean.

Validation

  • PHPCS: pass
  • PHPStan: pass
  • ESLint: pass
  • Stylelint: pass
  • CSpell: 197 files, 0 issues
  • Focused PHPUnit: QueueWorkers (8 tests, 225 assertions), MassSubscribeRoutes (2 tests, 29 assertions), ReportWorker (1 test, 4 assertions)
  • Parsed YAML comparison confirmed 32 formatting-only files are semantically unchanged; only the intended CI and library cleanup differ.
  • Independent Astra review: no remaining actionable findings.

The hosted DrupalCI matrix and coverage job remain the authoritative complete-suite verification for this merge request.

Merge request reports