Skip to content
Snippets Groups Projects
Andrei Vesterli's avatar
commented on merge request !28 "updated the version" at project / elogger

do it like this, please. You should not ignore the previous version.

Andrei Vesterli's avatar
commented on merge request !28 "updated the version" at project / elogger

"drupal/diff": ">=1.0 || >=2.0@beta",

sarwan verma's avatar
opened merge request !28 "updated the version" at project / elogger
Andrei Vesterli's avatar
pushed new tag 1.1.13 at project / elogger
Andrei Vesterli's avatar
pushed to branch 1.x at project / elogger
  • c6256c7c · 3430083, 3425325: Push these issues.
Andrei Vesterli's avatar
pushed to branch 1.x at project / elogger
  • c8d9f050 · Issue #3436075: \Drupal calls should be avoided in classes, use dep...
Andrei Vesterli's avatar
accepted merge request !27 "Fixed Drupal calls." at project / elogger
Andrei Vesterli's avatar
commented on merge request !27 "Fixed Drupal calls." at project / elogger
@param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler...
Andrei Vesterli's avatar
commented on merge request !27 "Fixed Drupal calls." at project / elogger

protected LoggerChannelFactoryInterface $loggerFactory;

Andrei Vesterli's avatar
commented on merge request !27 "Fixed Drupal calls." at project / elogger

protected ModuleHandlerInterface $moduleHandler

Chaitanya Dessai's avatar
opened merge request !27 "Fixed Drupal calls." at project / elogger
Thomas Gauges's avatar
commented on merge request !26 "Draft: #3419493 change field type of `diff` and `form_data` to `map`" at project / elogger

These changes also need to be implemented in an update hook.

Andrei Vesterli's avatar
commented on merge request !26 "Draft: #3419493 change field type of `diff` and `form_data` to `map`" at project / elogger

same as above

Andrei Vesterli's avatar
commented on merge request !26 "Draft: #3419493 change field type of `diff` and `form_data` to `map`" at project / elogger

missing the doxy plugin description. But, i would suggest to use phpcs/phpstan to sanitize these moments.

Andrei Vesterli's avatar
commented on merge request !26 "Draft: #3419493 change field type of `diff` and `form_data` to `map`" at project / elogger

label, field_types? You need to add them too and do not allow this formatted for all field types.

Andrei Vesterli's avatar
commented on merge request !26 "Draft: #3419493 change field type of `diff` and `form_data` to `map`" at project / elogger

all is good here but do not forget that the module is installed on many sites already so, think about compatibility too. You'll need to add a hook_...

Thomas Gauges's avatar
opened merge request !26 "Draft: #3419493 change field type of `diff` and `form_data` to `map`" at project / elogger
Andrei Vesterli's avatar
pushed new tag 1.1.12 at project / elogger
Andrei Vesterli's avatar
pushed to branch 1.x at project / elogger
  • 002b4952 · Issue #3401226 by darko_antunovic: Error: The script tried to call ...
Andrei Vesterli's avatar
accepted merge request !25 "Fix the error during the diff generator for multilangual websites." at project / elogger