Skip to content

Resolve #3147279 "Automated drupal 9"

drupal-check report attached. Got most of them. Also as it was heavily modifying the ElasticsearchTest.php I fixed most of the coding style issues as well.

 ------ ------------------------------------------------------------------------------------------- 
  Line   src/Event/BuildIndexParamsEvent.php                                                        
 ------ ------------------------------------------------------------------------------------------- 
  12     Class Drupal\elasticsearch_connector\Event\BuildIndexParamsEvent extends deprecated class  
         Symfony\Component\EventDispatcher\Event:                                                   
         since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead                   
 ------ ------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------- 
  Line   src/Event/BuildSearchParamsEvent.php                                                        
 ------ -------------------------------------------------------------------------------------------- 
  12     Class Drupal\elasticsearch_connector\Event\BuildSearchParamsEvent extends deprecated class  
         Symfony\Component\EventDispatcher\Event:                                                    
         since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead                    
 ------ -------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------- 
  Line   src/Event/PrepareIndexEvent.php                                                        
 ------ --------------------------------------------------------------------------------------- 
  12     Class Drupal\elasticsearch_connector\Event\PrepareIndexEvent extends deprecated class  
         Symfony\Component\EventDispatcher\Event:                                               
         since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead               
 ------ --------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------- 
  Line   src/Event/PrepareIndexMappingEvent.php                                                        
 ------ ---------------------------------------------------------------------------------------------- 
  12     Class Drupal\elasticsearch_connector\Event\PrepareIndexMappingEvent extends deprecated class  
         Symfony\Component\EventDispatcher\Event:                                                      
         since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead                      
 ------ ---------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------- 
  Line   src/Event/PrepareMappingEvent.php                                                        
 ------ ----------------------------------------------------------------------------------------- 
  12     Class Drupal\elasticsearch_connector\Event\PrepareMappingEvent extends deprecated class  
         Symfony\Component\EventDispatcher\Event:                                                 
         since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead                 
 ------ ----------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------- 
  Line   src/Event/PrepareSearchQueryEvent.php                                                        
 ------ --------------------------------------------------------------------------------------------- 
  12     Class Drupal\elasticsearch_connector\Event\PrepareSearchQueryEvent extends deprecated class  
         Symfony\Component\EventDispatcher\Event:                                                     
         since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead                     
 ------ --------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   tests/src/Behat/features/bootstrap/ElasticsearchConnectorFeatureContext.php   
 ------ ------------------------------------------------------------------------------ 
         Reflection error: Drupal\DrupalExtension\Context\RawDrupalContext not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols            
  12     Reflection error: Drupal\DrupalExtension\Context\RawDrupalContext not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols            
  12     Reflection error: Drupal\DrupalExtension\Context\RawDrupalContext not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols            
  12     Reflection error: Drupal\DrupalExtension\Context\RawDrupalContext not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols            
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/ElasticsearchTest.php                                               
 ------ ------------------------------------------------------------------------------------- 
  83     Call to deprecated method pass() of class Drupal\KernelTests\KernelTestBase:         
         in drupal:8.0.0 and is removed from drupal:10.0.0. PHPUnit                           
           interrupts a test as soon as a test assertion fails, so there is usually           
           no need to call this method. If a test's logic relies on this method,              
           refactor the test.                                                                 
  115    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  116    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  129    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  130    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  131    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  137    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  138    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  154    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  155    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  184    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  185    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  202    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  226    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  227    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  246    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  247    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  267    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  268    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  291    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  292    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  317    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  318    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  339    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  340    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  360    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  377    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  378    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  411    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  412    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  434    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  435    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  453    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  454    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  471    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  472    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  539    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  540    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  547    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.                                                     
  548    Call to deprecated method assertEqual() of class Drupal\KernelTests\KernelTestBase:  
         in drupal:8.0.0 and is removed from drupal:10.0.0. Use                               
           $this->assertEquals() instead.        

Merge request reports