fix: #3621385 Take the refused, allowed and page-title steps from varbase-e2e

Rajab Natshahrequested to merge
issue/educare-3621385:3621385-remove-the-local into 1.0.x

Issue: #3621385 Remove the three local step definitions now ambiguous with @vardot/varbase-e2e 2.0.4

Why

@vardot/varbase-e2e 2.0.4 ships three steps this recipe also defined locally, so Cucumber saw two definitions per sentence and failed the run with Multiple step definitions match — 36 of the 250 scenarios, 67 of the 1817 steps.

Then I should be refused "/admin/config/content/editoria11y"
Then I should be allowed "/admin/content"
And the page title should contain "Undergraduate Robotics Team Wins Regional Championship"

What changed

  • Deleted the three steps and their doc blocks from tests/step-definitions/educare.steps.js (lines 189, 212, 230). Everything else in that file is Educare's own and stays.
  • Dependency ^2 → ^2.0.4.
  • No feature file changes: the sentences are identical.

Keep the library ones: the refusal step passes on 403, 404, an access-denied page or a redirect to the log-in form where ours accepted only 403/404; should be allowed is its documented positive half; both are in docs/steps/navigation.md and docs/steps/assertion.md.

One difference to know about: the library page-title check is case-sensitive, ours was not. Both titles this suite asserts (08-01-seo-metatags.feature:23 and the outline at :74) already match the rendered case, so no scenario needed rewording.

Verified

npx cucumber-js --dry-run: 250 scenarios, 1817 steps, nothing ambiguous, nothing undefined (before: 36 ambiguous scenarios, 67 ambiguous steps). The browser suite needs an installed Educare site, so CI confirms the rest.

AI-Generated: Yes

Checkpoints:

  • File an issue
  • Addition/Change/Update/Fix
  • Testing to ensure no regression
  • Automated unit testing coverage
  • Automated functional testing coverage
  • UX/UI designer responsibilities
  • Readability
  • Accessibility
  • Performance
  • Security
  • Developer Documentation
  • User Guide Documentation
  • Reviewed by human
  • Code review by maintainers
  • Full testing and approval
  • Credit contributors
  • Review with the product owner
  • Release notes snippet
  • Release
Edited by Rajab Natshah

Merge request reports