Skip to content
Snippets Groups Projects

Issue #3500732 by mysdiir: Action that combines two lists.

Open mysdiir requested to merge issue/eca-3500732:3500732-combine-list into 3.0.x

Closes #3500732

Merge request reports

Members who can merge are allowed to add commits.
Code Quality is loading
Test summary results are being parsed
Ready to merge by members who can write to the target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
46 $form['list_token_left'] = [
47 '#type' => 'textfield',
48 '#title' => $this->t('Name of first list'),
49 '#description' => $this->t('The name of the first list that should be combined into a new one.'),
50 '#default_value' => $this->configuration['list_token_left'],
51 ];
52 $form['list_token_right'] = [
53 '#type' => 'textfield',
54 '#title' => $this->t('Name of second list'),
55 '#description' => $this->t('The name of the second list that should be combined into a new one.'),
56 '#default_value' => $this->configuration['list_token_right'],
57 ];
58
59 $debug = 1;
60
61 return $form;
  • Author Developer

    Within the bpmn_io modeller the inputted values into $form['list_token_left'] and $form['list_token_right'] won't get saved when clicking into another element outside this action. The 'normal' eca behaviour is that even without saving, the inputted values still persist, this is not happening in my case.

    There are no errors in my browsers console or new log messages in recent log messages.

  • Author Developer

    I went a little further into investigation and it seems that the $form_state does not handle the inputted values however.

  • I can't reproduce any problem with this. Should all be fine, unless you're keeping an action in a model, then change the config form. That doesn't work. You need to remove the action from the model and add it again, if it comes with a changed config form. Or you run drush eca:update which updates the model data to cover the current config form defintions.

  • Author Developer

    Worked :) Thanks for that suggestion.

  • Please register or sign in to reply
  • mysdiir
    mysdiir @Mysdiir started a thread on commit c40d948d
  • 47 '#type' => 'textfield',
    48 '#title' => $this->t('Name of first list'),
    49 '#description' => $this->t('The name of the first list that should be combined into a new one.'),
    50 '#default_value' => $this->configuration['list_token_left'],
    51 ];
    52 $form['list_token_right'] = [
    53 '#type' => 'textfield',
    54 '#title' => $this->t('Name of second list'),
    55 '#description' => $this->t('The name of the second list that should be combined into a new one.'),
    56 '#default_value' => $this->configuration['list_token_right'],
    57 ];
    58
    59 $debug = 1;
    60
    61 return $form;
    62 }
    • Author Developer

      Also the entity field in the configuration form is not necessary but I'm not sure how to remove it (s. screenshot). When taking a look into the $form array within m debugger, this is not defined, so I assume it must be inherited by another class.

      Screenshot_2025-02-02_at_19.05.56

    • That field is added by ECA automatically, because the annotation of your action plugin says, that it has a type = entity. If your action plugin is not entity related, then that line needs to be removed from the annotation, then the field will no longer be there after a drush cr.

    • Author Developer

      Also worked :)

    • Please register or sign in to reply
  • mysdiir added 1 commit

    added 1 commit

    Compare with previous version

  • mysdiir added 1 commit

    added 1 commit

    Compare with previous version

  • mysdiir marked this merge request as ready

    marked this merge request as ready

  • mysdiir changed title from Draft: (WIP) Issue #3500732 by mysdiir: Action that combines two lists. to Issue #3500732 by mysdiir: Action that combines two lists.

    changed title from Draft: (WIP) Issue #3500732 by mysdiir: Action that combines two lists. to Issue #3500732 by mysdiir: Action that combines two lists.

  • mysdiir added 1 commit

    added 1 commit

    Compare with previous version

  • mysdiir added 1 commit

    added 1 commit

    Compare with previous version

  • mysdiir added 1 commit

    added 1 commit

    • 0645c89e - #3500732 - Adjustung wrong used configuration key for adding token data.

    Compare with previous version

  • Jürgen Haas
  • Jürgen Haas
  • Jürgen Haas
    • Resolved by mysdiir

      Thanks for your replies as a first review. Those are valuable lessons for me :).

      I wonder how you evaluate the approach of the isEqual() method along with its implementation and general idea? If I'd appreciate some feedback about this :).

  • mysdiir added 2 commits

    added 2 commits

    • 6a6ffd7c - #3500732 - Simplifying merge logic after maintainer review.
    • f99e5240 - Merge branch '3500732-combine-list' of git.drupal.org:issue/eca-3500732 into 3500732-combine-list

    Compare with previous version

  • mysdiir resolved all threads

    resolved all threads

  • mysdiir added 1 commit

    added 1 commit

    Compare with previous version

  • mysdiir added 1 commit

    added 1 commit

    Compare with previous version

  • Jürgen Haas
  • mysdiir added 1 commit

    added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading