10.2 fixes

Signed-off-by: Jibran Ijaz jibran.ijaz@gmail.com

Closes #3384721

src/Plugin/Field/FieldType/DynamicEntityReferenceItem.php

@@ -2,6 +2,7 @@
 
 namespace Drupal\dynamic_entity_reference\Plugin\Field\FieldType;
 
+use Drupal\Component\Utility\DeprecationHelper;
 use Drupal\Component\Utility\Html;
 use Drupal\Core\Entity\ContentEntityTypeInterface;
 use Drupal\Core\Entity\EntityInterface;
@@ -11,6 +12,7 @@ use Drupal\Core\Field\FieldItemBase;
 use Drupal\Core\Field\FieldStorageDefinitionInterface;
 use Drupal\Core\Field\Plugin\Field\FieldType\EntityReferenceItem;
 use Drupal\Core\Form\FormStateInterface;
+use Drupal\Core\Form\SubformState;
 use Drupal\Core\Session\AccountInterface;
 use Drupal\Core\StringTranslation\TranslatableMarkup;
 use Drupal\Core\TypedData\DataReferenceTargetDefinition;
@@ -240,11 +242,21 @@ class DynamicEntityReferenceItem extends EntityReferenceItem {
     $options = array_filter(array_keys($labels[(string) t('Content', [], ['context' => 'Entity type group'])]), function ($entity_type_id) {
       return static::entityHasIntegerId($entity_type_id);
     });
-    $exclude_entity_types = $form_state->getValue([
+    // 10.2 combined the field storage form into the field config form. To get
+    // the field values we want, we need to either use the passed form state
+    // for 10.1 and below, or create a subform state for 10.2 and above.
+    // @see \Drupal\field_ui\Form\FieldConfigEditForm::validateForm
+    $subform_state = DeprecationHelper::backwardsCompatibleCall(
+      \Drupal::VERSION,
+      10.2,
+      fn() => SubformState::createForSubform($form['field_storage']['subform'], $form, $form_state),
+      fn() => $form_state
+    );
+    $exclude_entity_types = $subform_state->getValue([
       'settings',
       'exclude_entity_types',
     ], 0);
-    $entity_type_ids = $form_state->getValue([
+    $entity_type_ids = $subform_state->getValue([
       'settings',
       'entity_type_ids',
     ], []);