Refactor SA title creation into it's own function, hide fields on SAs unless a...

Refactor SA title creation into it's own function, hide fields on SAs unless a user has specific permissions.

Closes #3473445

added 2 commits

• 913712f7 - 1 commit from branch project:7.x-3.x
• 41af5342 - Refactor SA title creation into it's own function, hide fields on SAs unless a...

Compare with previous version

Realized I should have used field_access(), refactoring.

added 1 commit

• 9e38e648 - Use drupalorg_field_access() to control viewing/editing.

Compare with previous version

added 1 commit

• e15f3154 - Small documentation edit.

Compare with previous version

added 1 commit

• 608905f5 - Add some logic so the restrictions are limited to SAs

Compare with previous version

added 1 commit

• 379dd920 - Add slighty improved logic.

Compare with previous version

requested changes

added 1 commit

• 4290b022 - Simplify access and refactor _drupalorg_sa_title()

Compare with previous version

added 1 commit

• d39e2d8f - Refactor logic for node access to avoid errors when editing

Compare with previous version

I think this is in a much better spot now, thanks for the thorough review.

added 1 commit

• ea2e4b2a - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• a0676010 - Pull out useless node status check

Compare with previous version

added 1 commit

• 0be99b6d - Pull out the other useless node status check

Compare with previous version

added 1 commit

• 6b8d14c2 - Add issue status change back in, not sure why it got pulled out in the first place

Compare with previous version

added 1 commit

• d2014906 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit

• 86814f03 - Make logic more straightforward

Compare with previous version

added 1 commit

• 93a34ab6 - Remove unused variable

Compare with previous version

resolved all threads

added 1 commit

• 53b0eda4 - Fix notice

Compare with previous version

added 1 commit

• d52999d0 - Check for node status before deciding on which title to save

Compare with previous version

resolved all threads

added 1 commit

• d13208d7 - Fix notice for vuln type

Compare with previous version

added 1 commit

• 937b23ab - Might not need this access control any more

Compare with previous version

added 1 commit

• 8477fdc9 - Removed some unneeded title/content display

Compare with previous version

added 1 commit

• e9211d6e - Pull some date/time content out of logic flow

Compare with previous version

added 1 commit

• 45536a6e - Indentation

Compare with previous version

resolved all threads

resolved all threads

added 1 commit

• 73ebb345 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

resolved all threads

added 1 commit

• 017c84db - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 2 commits

• b12b65c5 - Remove extra assignment
• 7ee541a6 - Remove extra checks

Compare with previous version

approved this merge request

added 33 commits

• 7ee541a6...14f0f227 - 9 commits from branch project:7.x-3.x
• 14f0f227...875c8b56 - 14 earlier commits
• f4d6b056 - Check for node status before deciding on which title to save
• 10ab22fd - Fix notice for vuln type
• d191d401 - Might not need this access control any more
• ea7966ff - Removed some unneeded title/content display
• 0cd6c9d9 - Pull some date/time content out of logic flow
• 6b66a858 - Indentation
• e29ab6a4 - Apply 1 suggestion(s) to 1 file(s)
• bfda46ba - Apply 1 suggestion(s) to 1 file(s)
• 03c4608f - Remove extra assignment
• c9e56173 - Remove extra checks

Compare with previous version

merged