Issue #3266208: Reimplement issue commit comments to trigger on webhook invocation
Merge request reports
Activity
added 1 commit
- 25489c8d - Validation on the issue and first steps to render the comment.
added 1 commit
- c2523733 - Bringing the required data in the correct format.
added 1 commit
- 0ae6f716 - Use email to find committer and author drupal users.
- Resolved by Neil Drumm
One part of the old system I don’t see is https://git.drupalcode.org/project/drupalorg/-/blob/6161f1e31659137ed904816531da0637730f955d/drupalorg_versioncontrol/drupalorg_versioncontrol.module#L136-161
That’s basically there so if a maintainer has made a commit related to an issue that’s still open, it doesn’t notify too much if they are using feature branches in the project’s repository. That might not be relevant, depending on what GitLab gives us in the webhook payloads, there’s a bit more detail in one of the comments in this review.
- Last reply by Neil Drumm
added 2 commits
added 20 commits
-
a9b8cb05...df8ec3cb - 8 commits from branch
project:7.x-3.x - 39cf7044 - WIP wiring the queue to the hook.
- 472bcd49 - More logic using gitlab api.
- 08d0dd39 - Validation on the issue and first steps to render the comment.
- a26fdb85 - More comments. WIP.
- e159bac8 - Bringing the required data in the correct format.
- a962a752 - PHP feature might not be available.
- 8a481e07 - First draft completed.
- f8963023 - Use email to find committer and author drupal users.
- 6928acb7 - Array instead of object.
- 921cc37d - Addressing some of the feedback.
- f9cecc60 - Only try to make comments on branches.
- 0413fb4f - Consider multiple refs in one push.
Toggle commit list-
a9b8cb05...df8ec3cb - 8 commits from branch
Please register or sign in to reply