Issue #3485549 by jurgenhaas, pameeela, phenaproxima: Improve manual account creation process

composer.json

@@ -4,10 +4,10 @@
     "description": "Sets up a site with useful authentication features.",
     "version": "dev-main",
     "require": {
-        "drupal/bpmn_io": "^2.0",
+        "drupal/bpmn_io": "2.1.x-dev",
         "drupal/core": ">=10.3",
         "drupal/eca": "2.1.x-dev",
         "drupal/login_emailusername": "^3",
-        "drupal/token": "^1.15"
+        "drupal/token": "^1"
     }
 }

config/eca.eca.user_register.yml

+langcode: en
+status: true
+dependencies:
+  module:
+    - eca_base
+    - eca_form
+id: user_register
+modeller: bpmn_io
+label: 'User registration'
+version: 0.0.0
+weight: 0
+events:
+  Event_build_user_reg_form:
+    plugin: 'form:form_build'
+    label: 'Build user register form'
+    configuration:
+      form_id: user-register-form
+      entity_type_id: ''
+      bundle: ''
+      operation: ''
+    successors:
+      -
+        id: Activity_set_weight_mail
+        condition: ''
+  Event_validate_user_reg_form:
+    plugin: 'form:form_validate'
+    label: 'Validate user register form'
+    configuration:
+      form_id: user-register-form
+      entity_type_id: ''
+      bundle: ''
+      operation: ''
+    successors:
+      -
+        id: Activity_get_random_string
+        condition: Flow_notify_on
+conditions:
+  Flow_notify_on:
+    plugin: eca_form_field_value
+    configuration:
+      negate: false
+      case: false
+      field_value: '1'
+      field_name: notify
+      strip_tags: true
+      trim: true
+      xss_filter: true
+      operator: equal
+      type: numeric
+gateways: {  }
+actions:
+  Activity_password_field_not_required:
+    plugin: eca_form_field_require
+    label: 'Set password as not required'
+    configuration:
+      flag: false
+      field_name: pass
+    successors:
+      -
+        id: Activity_invisible_state_password
+        condition: ''
+  Activity_get_random_string:
+    plugin: eca_token_set_random_value
+    label: 'Get random string'
+    configuration:
+      token_name: password
+      mode: password
+      length: true
+    successors:
+      -
+        id: Activity_set_password
+        condition: ''
+  Activity_set_password:
+    plugin: eca_form_field_set_value
+    label: 'Set password'
+    configuration:
+      field_value: '[password]'
+      use_yaml: false
+      field_name: pass
+      strip_tags: false
+      trim: false
+      xss_filter: false
+    successors:
+      -
+        id: Activity_set_status
+        condition: ''
+  Activity_set_weight_mail:
+    plugin: eca_form_field_set_weight
+    label: 'Set weight for mail'
+    configuration:
+      weight: '-10'
+      field_name: mail
+    successors:
+      -
+        id: Activity_set_weight_name
+        condition: ''
+  Activity_set_weight_name:
+    plugin: eca_form_field_set_weight
+    label: 'Set weight for name'
+    configuration:
+      weight: '-9'
+      field_name: name
+    successors:
+      -
+        id: Activity_set_weight_notify
+        condition: ''
+  Activity_set_weight_notify:
+    plugin: eca_form_field_set_weight
+    label: 'Set weight for notify'
+    configuration:
+      weight: '-8'
+      field_name: notify
+    successors:
+      -
+        id: Activity_set_weight_password
+        condition: ''
+      -
+        id: Activity_enable_notify
+        condition: ''
+  Activity_set_weight_password:
+    plugin: eca_form_field_set_weight
+    label: 'Set weight for password'
+    configuration:
+      weight: '-7'
+      field_name: pass
+    successors:
+      -
+        id: Activity_password_field_not_required
+        condition: ''
+      -
+        id: Activity_invisible_state_status
+        condition: ''
+  Activity_enable_notify:
+    plugin: eca_form_field_default_value
+    label: 'Enable notify by default'
+    configuration:
+      value: '1'
+      field_name: notify
+      strip_tags: true
+      trim: true
+      xss_filter: true
+    successors: {  }
+  Activity_invisible_state_status:
+    plugin: eca_form_field_add_state
+    label: 'Add invisible state for status'
+    configuration:
+      selector: ':input[name="notify"]'
+      state: invisible
+      condition: checked
+      value: ''
+      field_name: status
+    successors: {  }
+  Activity_invisible_state_password:
+    plugin: eca_form_field_add_state
+    label: 'Add invisible state for password'
+    configuration:
+      selector: ':input[name="notify"]'
+      state: invisible
+      condition: checked
+      value: ''
+      field_name: pass
+    successors: {  }
+  Activity_set_status:
+    plugin: eca_form_field_set_value
+    label: 'Set status'
+    configuration:
+      field_value: '1'
+      use_yaml: false
+      field_name: status
+      strip_tags: true
+      trim: true
+      xss_filter: true
+    successors: {  }

recipe.yml

@@ -4,6 +4,7 @@ type: Drupal CMS
 install:
   - bpmn_io
   - eca_base
+  - eca_form
   - eca_misc
   - eca_user
   - login_emailusername

tests/e2e/spec.cy.js

+describe('Authentication tweaks', () => {
+
+  beforeEach(() => {
+    cy.setUp('standard').applyRecipe();
+  });
+
+  after(() => {
+    cy.tearDown();
+  });
+
+  it('hides the password field if user will be notified of new account', () => {
+    cy.drupalLogin('admin');
+    cy.visit('/admin/people/create');
+
+    const notifyCheckbox = cy.findByLabelText('Notify user of new account')
+      .should('be.checked');
+    const passwordField = cy.findByLabelText('Password')
+      .should('exist')
+      .and('not.be.visible');
+    notifyCheckbox.uncheck();
+    passwordField.should('be.visible').and('be.empty');
+    cy.findByLabelText('Confirm password')
+      .should('exist')
+      .and('be.empty')
+      .and('not.be.visible');
+    notifyCheckbox.check();
+
+    cy.findByLabelText('Email address').type('chef@drupal.local');
+    cy.findByLabelText('Username').type('chef');
+    cy.findByDisplayValue('Create new account').click();
+    cy.get('[data-drupal-messages]').should('contain.text', 'A welcome message with further instructions has been emailed to the new user chef.');
+  });
+
+})

tests/src/Functional/RedirectsTest.php

@@ -28,7 +28,6 @@ class RedirectsTest extends BrowserTestBase {
     // Apply the recipe again to prove that it's idempotent.
     $this->applyRecipe($dir);
 
-    $session = $this->getSession();
     $assert_session = $this->assertSession();
 
     // A 403 should redirect to the login page, forwarding to the original