Skip to content
Snippets Groups Projects

Issue #3497388 by Alyciamjones, jwitkowski79: Implement designs for Paragraph...

Merged Issue #3497388 by Alyciamjones, jwitkowski79: Implement designs for Paragraph...
issue/drupal_cms-3497388:paragraph-component into 1.x
1 open thread
Merged
Amine Boulaffasrequested to merge
issue/drupal_cms-3497388:paragraph-component into 1.x
1 open thread

Issue #3497388 by Alyciamjones, jwitkowski79: Implement designs for Paragraph component within Olivero for XB

Merge request reports

Merge request pipeline #391210 skipped

Merge request pipeline skipped for 910a4004

Merged by Adam G-HAdam G-H 8 months ago (Jan 9, 2025 8:27pm UTC)

Loading

Pipeline #391211 passed

Stage: test
Stage: deploy

Pipeline passed for f18f41af on 1.x

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
drupal_cms_olivero/components/paragraph/paragraph.css 0 → 100644
6 @media (min-width: 1024px) {
7 .paragraph {
8 display: grid;
9 grid-template-columns: repeat(12, minmax(0, 1fr));
10 }
11
12 .paragraph__content {
13 grid-column: 3 / 10;
14 grid-column-start: 3;
15 }
16 }
17
18 .paragraph--large {
19 font-size: 1.5rem;
20 font-weight: 700;
21 line-height: 2.8125rem;
  • Heikki Ylipaavalniemi
    Heikki Ylipaavalniemi @HeikkiY

    This might be out of scope for this issue but is there a reason why some of the variations are using CSS variables but for example the large one is not?

    It looks very clear in the other variations that the line height is coming from the base variable but here it's not that obvious.

    Since this issue is very time critical, it's not a huge deal but is there for example a follow-up issue where these text styles would be unified with CSS variables? It would make it much easier for developers just looking at the CSS without the Figma link to understand the logic.

    Would be also really nice if it would be possible to find the Figma link later from Git.

  • Kristen Pol
    Kristen Pol @kepol

    I suggest we handle this here:

    https://www.drupal.org/project/drupal_cms/issues/3498590

  • Please register or sign in to reply
  • Kristen Pol added 1 commit

    added 1 commit

    • 4c6fbfe5 - Remove attributes, change status & formatting.

    Compare with previous version

  • Adam G-H added 17 commits

    added 17 commits

    • 4c6fbfe5...17b722de - 10 commits from branch project:1.x
    • eae01dad - Issue #3497388 by Alyciamjones, jwitkowski79: Implement designs for Paragraph...
    • daf7860f - Issue #3497388 by boulaffasae, ckrina, Alyciamjones, jwitkowski79: Implement...
    • a1f99252 - Issue #3497388 by boulaffasae, ckrina, Alyciamjones, jwitkowski79: Implement...
    • 4a74bd41 - Issue #3497388 by boulaffasae, ckrina, Alyciamjones, jwitkowski79: Implement...
    • c3943bf5 - Tweaks to paragraph component
    • 0010ad1c - Use textarea for paragraph text prop
    • 910a4004 - Remove attributes, change status & formatting.

    Compare with previous version

    Toggle commit list
  • Adam G-H merged

    merged

    • Please register or sign in to reply