Skip to content
Snippets Groups Projects

Resolve #3479721 "Create placeholder blocks for welcome dashboard"

Open Resolve #3479721 "Create placeholder blocks for welcome dashboard"
issue/drupal_cms-3479721:3479721-dashboard-configuration into 0.x
3 unresolved threads
Open Christian López Espínola requested to merge issue/drupal_cms-3479721:3479721-dashboard-configuration into 0.x
3 unresolved threads

Create placeholder blocks for welcome dashboard

Closes #3479721

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Adam G-H
  • Adam G-H
  • Adam G-H
  • Christian López Espínola added 8 commits

    added 8 commits

    Compare with previous version

    Toggle commit list
  • Christian López Espínola added 9 commits

    added 9 commits

    Compare with previous version

    Toggle commit list
  • Christian López Espínola added 1 commit

    added 1 commit

    Compare with previous version

  • Christian López Espínola added 9 commits

    added 9 commits

    Compare with previous version

    Toggle commit list
  • Christian López Espínola added 7 commits

    added 7 commits

    • bfaf9e9f - 1 commit from branch project:0.x
    • d509f90b - Include every config from dashboard.
    • 816999b0 - Define block placeholders for the welcome dashboard.
    • aec96e60 - Added content and site status blocks.
    • 0c8c1fb7 - Remove uuids in provided config.
    • a2c7c9e4 - Changed message.
    • 3451a111 - Added todo.

    Compare with previous version

    Toggle commit list
  • Christian López Espínola added 20 commits

    added 20 commits

    Compare with previous version

    Toggle commit list
  • Adam G-H resolved all threads

    resolved all threads

  • Adam G-H
    Adam G-H @phenaproxima started a thread on the diff
    • drupal_cms_dashboard/config/dashboard.dashboard.welcome.yml
    42 value: '<div class="panel field-config-form form-wrapper"><a class="field-config-form button button-primary" href="/node/add/page" title="Add a Page.">Add a Page </a><a class="field-config-form button button-primary" href="/node/add/event" title="Add an Event.">Add an Event</a> <a class="field-config-form button button-primary" href="/node/add/blog" title="Write a Post.">Write a Post</a></div>'
    43 format: full_html
    44 weight: 0
    45 additional: { }
    46 12b73735-da0a-4abb-8d8f-25ead4d7ae1c:
    47 uuid: 12b73735-da0a-4abb-8d8f-25ead4d7ae1c
    48 region: first
    49 configuration:
    50 id: dashboard_text_block
    51 label: 'Add new capabilities'
    52 label_display: visible
    53 provider: dashboard
    54 context_mapping: { }
    55 text:
    56 value: '<p>SEO, Content types, New content, Analytics</p>'
    57 format: basic_html
  • Adam G-H
    Adam G-H @phenaproxima started a thread on the diff
    • drupal_cms_dashboard/config/dashboard.dashboard.welcome.yml
    55 text:
    56 value: '<p>SEO, Content types, New content, Analytics</p>'
    57 format: basic_html
    58 weight: 1
    59 additional: { }
    60 c71d5d22-6031-40d0-91f3-f55d96eff403:
    61 uuid: c71d5d22-6031-40d0-91f3-f55d96eff403
    62 region: first
    63 configuration:
    64 id: dashboard_text_block
    65 label: 'Site Analytics'
    66 label_display: visible
    67 provider: dashboard
    68 context_mapping: { }
    69 text:
    70 value: '<p>Coming soon...</p>'
    • Adam G-H
      Adam G-H @phenaproxima
      Maintainer

      Not blocking, but is this really necessary? A "coming soon" block is lamesville, and leaves a poor impression. :) If this is going to land soon, like a week or so, then I would have less of a problem with this block...but I have absolutely no idea when analytics will actually appear in Drupal CMS, since the track lead has been rather silent.

      Edited by Adam G-H
    • Please register or sign in to reply
  • Adam G-H
    Adam G-H @phenaproxima started a thread on the diff
    • drupal_cms_dashboard/config/dashboard.dashboard.welcome.yml
    89 label: Content
    90 context_mapping: { }
    91 components:
    92 4b5cf306-ac12-468a-b540-61d8aba81a3a:
    93 uuid: 4b5cf306-ac12-468a-b540-61d8aba81a3a
    94 region: content
    95 configuration:
    96 id: 'views_block:dashboard_content-block_site_content'
    97 label: ''
    98 label_display: visible
    99 provider: views
    100 context_mapping: { }
    101 views_label: ''
    102 items_per_page: none
    103 weight: 0
    104 additional: { }
    • Adam G-H
      Adam G-H @phenaproxima
      Maintainer

      I think we need to extend our test to prove that, if you log in as a content editor, all of these blocks are visible to you. Unfortunately this is probably commit-blocking. But you could write the test in Cypress if you like, or just alter the existing PHPUnit test.

    • Please register or sign in to reply
    Please register or sign in to reply