Skip to content
Snippets Groups Projects
Verified Commit f0c16a29 authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3410312 by catch: Flood database backend ::isAllowed() should call ::ensureTableExists()

(cherry picked from commit a3f1255f)
parent e671b542
Branches
Tags
16 merge requests!8376Drupal views: adding more granularity to the ‘use ajax’ functionality,!8300Issue #3443586 View area displays even when parent view has no results.,!7567Issue #3153723 by quietone, Hardik_Patel_12: Change the scaffolding...,!7565Issue #3153723 by quietone, Hardik_Patel_12: Change the scaffolding...,!7509Change label "Block description" to "Block type",!7344Issue #3292350 by O'Briat, KlemenDEV, hswong3i, smustgrave, quietone: Update...,!6922Issue #3412959 by quietone, smustgrave, longwave: Fix 12 'un' words,!6848Issue #3417553 by longwave: Remove withConsecutive() in CacheCollectorTest,!6720Revert "Issue #3358581 by pfrenssen, _tarik_, a.dmitriiev, smustgrave:...,!6560Update ClaroPreRender.php, confirming classes provided are in array format,!6528Issue #3414261 by catch: Add authenticated user umami performance tests,!6501Issue #3263668 by omkar-pd, Wim Leers, hooroomoo: Re-enable inline form errors...,!6354Draft: Issue #3380392 by phma: Updating language weight from the overview reverts label if translated,!6324Issue #3416723 by Ludo.R: Provide a "node type" views default argument,!6119Issue #3405704 by Spokje, longwave: symfony/psr-http-message-bridge major version bump,!5950Issue #3403653 by alexpott, longwave: Incorporate improvements to how contrib runs PHPStan to core
Pipeline #67120 passed with warnings
Pipeline: drupal

#67135

    Pipeline: drupal

    #67133

      Pipeline: drupal

      #67129

        +1
        ......@@ -140,7 +140,9 @@ public function isAllowed($name, $threshold, $window = 3600, $identifier = NULL)
        return ($number < $threshold);
        }
        catch (\Exception $e) {
        $this->catchException($e);
        if (!$this->ensureTableExists()) {
        throw $e;
        }
        return TRUE;
        }
        }
        ......
        ......@@ -60,7 +60,7 @@ public function testAnonymous() {
        // the highest and lowest number of observed during test runs.
        // See https://www.drupal.org/project/drupal/issues/3402610
        $this->assertGreaterThanOrEqual(58, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(67, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(68, $performance_data->getQueryCount());
        $this->assertGreaterThanOrEqual(129, $performance_data->getCacheGetCount());
        $this->assertLessThanOrEqual(132, $performance_data->getCacheGetCount());
        $this->assertGreaterThanOrEqual(59, $performance_data->getCacheSetCount());
        ......@@ -131,7 +131,7 @@ public function testLogin(): void {
        // random test failures, assert greater than equal the highest and lowest
        // number of queries observed during test runs.
        // See https://www.drupal.org/project/drupal/issues/3402610
        $this->assertLessThanOrEqual(42, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(39, $performance_data->getQueryCount());
        $this->assertGreaterThanOrEqual(39, $performance_data->getQueryCount());
        $this->assertSame(28, $performance_data->getCacheGetCount());
        $this->assertLessThanOrEqual(2, $performance_data->getCacheSetCount());
        ......@@ -163,14 +163,15 @@ public function testLoginBlock(): void {
        $performance_data = $this->collectPerformanceData(function () use ($account) {
        $this->submitLoginForm($account);
        });
        $this->assertLessThanOrEqual(51, $performance_data->getQueryCount());
        $this->assertLessThanOrEqual(50, $performance_data->getQueryCount());
        $this->assertGreaterThanOrEqual(48, $performance_data->getQueryCount());
        $this->assertSame(30, $performance_data->getCacheGetCount());
        // This test observes a variable number of cache sets, so to avoid random
        // This test observes a variable number of cache operations, so to avoid random
        // test failures, assert greater than equal the highest and lowest number
        // observed during test runs.
        // See https://www.drupal.org/project/drupal/issues/3402610
        $this->assertLessThanOrEqual(32, $performance_data->getCacheGetCount());
        $this->assertGreaterThanOrEqual(30, $performance_data->getCacheGetCount());
        $this->assertLessThanOrEqual(4, $performance_data->getCacheSetCount());
        $this->assertGreaterThanOrEqual(1, $performance_data->getCacheSetCount());
        $this->assertSame(1, $performance_data->getCacheDeleteCount());
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment