Commit de2436f1 authored by catch's avatar catch
Browse files

Issue #3497701 by mstrelan, spokje, catch, quietone: [random test failure]... 

Issue #3497701 by mstrelan, spokje, catch, quietone: [random test failure] PackageUpdateTest::testPackageUpdate

(cherry picked from commit e11fda57)
parent 33160a9b

core/modules/package_manager/tests/modules/package_manager_test_api/src/ApiController.php

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ public function run(Request $request): RedirectResponse { 
  public function finish(string $id): Response {

    $this->stage->claim($id)->postApply();

    $this->stage->destroy();

    return new Response();

    return new Response('Finished');

  }



  /**

core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php

+3 −0
Original line number Diff line number Diff line
@@ -721,6 +721,9 @@ protected function makePackageManagerTestApiRequest(string $url, array $query_da 
      $this->serverErrorLog,

    );

    $this->assertSame(200, $session->getStatusCode(), $message);

    // Sometimes we get a 200 response after a PHP timeout or OOM error, so we

    // also check the page content to ensure it's what we expect.

    $this->assertSame('Finished', $session->getPage()->getText());

  }



  /**

core/tests/Drupal/BuildTests/Framework/BuildTestBase.php

+2 −2
Original line number Diff line number Diff line
@@ -333,8 +333,8 @@ public function assertCommandExitCode($expected_code) { 
  public function executeCommand($command_line, $working_dir = NULL) {

    $this->commandProcess = Process::fromShellCommandline($command_line);

    $this->commandProcess->setWorkingDirectory($this->getWorkingPath($working_dir))

      ->setTimeout(300)

      ->setIdleTimeout(300);

      ->setTimeout(360)

      ->setIdleTimeout(360);

    $this->commandProcess->run();

    return $this->commandProcess;

  }