Commit d7fa47b4 authored by catch's avatar catch

Issue #1605290 by amateescu, msonnabaum, Caseledde, damiankloip, beejeebus,...

Issue #1605290 by amateescu, msonnabaum, Caseledde, damiankloip, beejeebus, catch, Berdir, Wim Leers: Enable entity render caching with cache tag support.
parent bb29548d
......@@ -4139,7 +4139,7 @@ function drupal_render_cache_set(&$markup, $elements) {
}
$bin = isset($elements['#cache']['bin']) ? $elements['#cache']['bin'] : 'cache';
$expire = isset($elements['#cache']['expire']) ? $elements['#cache']['expire'] : CacheBackendInterface::CACHE_PERMANENT;
$tags = isset($elements['#cache']['tags']) ? $elements['#cache']['tags'] : array();
$tags = drupal_render_collect_cache_tags($elements);
cache($bin)->set($cid, $data, $expire, $tags);
}
......@@ -4186,6 +4186,50 @@ function drupal_render_collect_attached($elements, $return = FALSE) {
}
}
/**
* Collects cache tags for an element and its children into a single array.
*
* The cache tags array is returned in a format that is valid for
* \Drupal\Core\Cache\CacheBackendInterface::set().
*
* When caching elements, it is necessary to collect all cache tags into a
* single array, from both the element itself and all child elements. This
* allows items to be invalidated based on all tags attached to the content
* they're constituted from.
*
* @param array $element
* The element to collect cache tags from.
* @param array $tags
* (optional) An array of already collected cache tags (i.e. from a parent
* element). Defaults to an empty array.
*
* @return array
* The cache tags array for this element and its descendants.
*/
function drupal_render_collect_cache_tags($element, $tags = array()) {
if (isset($element['#cache']['tags'])) {
foreach ($element['#cache']['tags'] as $namespace => $values) {
if (is_array($values)) {
foreach ($values as $value) {
$tags[$namespace][$value] = $value;
}
}
else {
if (!isset($tags[$namespace])) {
$tags[$namespace] = $values;
}
}
}
}
if ($children = element_children($element)) {
foreach ($children as $child) {
$tags = drupal_render_collect_cache_tags($element[$child], $tags);
}
}
return $tags;
}
/**
* Prepares an element for caching based on a query.
*
......
......@@ -46,6 +46,18 @@ function entity_info_cache_clear() {
\Drupal::entityManager()->clearCachedFieldDefinitions();
}
/**
* Clears the entity render cache for all entity types.
*/
function entity_render_cache_clear() {
$entity_manager = Drupal::entityManager();
foreach ($entity_manager->getDefinitions() as $entity_type => $info) {
if ($entity_manager->hasController($entity_type, 'render')) {
$entity_manager->getRenderController($entity_type)->resetCache();
}
}
}
/**
* Returns the entity bundle info.
*
......@@ -611,14 +623,19 @@ function entity_render_controller($entity_type) {
* @param string $langcode
* (optional) For which language the entity should be rendered, defaults to
* the current content language.
* @param bool $reset
* (optional) Whether to reset the render cache for the requested entity.
* Defaults to FALSE.
*
* @return array
* A render array for the entity.
*/
function entity_view(EntityInterface $entity, $view_mode, $langcode = NULL) {
return \Drupal::entityManager()
->getRenderController($entity->entityType())
->view($entity, $view_mode, $langcode);
function entity_view(EntityInterface $entity, $view_mode, $langcode = NULL, $reset = FALSE) {
$render_controller = \Drupal::entityManager()->getRenderController($entity->entityType());
if ($reset) {
$render_controller->resetCache(array($entity->id()));
}
return $render_controller->view($entity, $view_mode, $langcode);
}
/**
......@@ -631,15 +648,20 @@ function entity_view(EntityInterface $entity, $view_mode, $langcode = NULL) {
* @param string $langcode
* (optional) For which language the entity should be rendered, defaults to
* the current content language.
* @param bool $reset
* (optional) Whether to reset the render cache for the requested entities.
* Defaults to FALSE.
*
* @return array
* A render array for the entities, indexed by the same keys as the
* entities array passed in $entities.
*/
function entity_view_multiple(array $entities, $view_mode, $langcode = NULL) {
return \Drupal::entityManager()
->getRenderController(reset($entities)->entityType())
->viewMultiple($entities, $view_mode, $langcode);
function entity_view_multiple(array $entities, $view_mode, $langcode = NULL, $reset = FALSE) {
$render_controller = \Drupal::entityManager()->getRenderController(reset($entities)->entityType());
if ($reset) {
$render_controller->resetCache(array_keys($entities));
}
return $render_controller->viewMultiple($entities, $view_mode, $langcode);
}
/**
......
......@@ -137,6 +137,14 @@ class EntityType extends Plugin {
*/
public $static_cache = TRUE;
/**
* Boolean indicating whether the rendered output of entities should be
* cached.
*
* @var bool (optional)
*/
public $render_cache = TRUE;
/**
* Boolean indicating whether entities of this type have multilingual support.
*
......
......@@ -8,6 +8,7 @@
namespace Drupal\Core\Entity;
use Drupal\Component\Uuid\Uuid;
use Drupal\Core\Entity\Plugin\DataType\EntityReferenceItem;
use Drupal\Core\Language\Language;
use Drupal\Core\TypedData\TranslatableInterface;
use Drupal\Core\TypedData\TypedDataInterface;
......@@ -611,6 +612,7 @@ public function preSave(EntityStorageControllerInterface $storage_controller) {
* {@inheritdoc}
*/
public function postSave(EntityStorageControllerInterface $storage_controller, $update = TRUE) {
$this->changed();
}
/**
......@@ -635,6 +637,9 @@ public static function preDelete(EntityStorageControllerInterface $storage_contr
* {@inheritdoc}
*/
public static function postDelete(EntityStorageControllerInterface $storage_controller, array $entities) {
foreach ($entities as $entity) {
$entity->changed();
}
}
/**
......@@ -698,4 +703,47 @@ public static function baseFieldDefinitions($entity_type) {
return array();
}
/**
* {@inheritdoc}
*/
public function referencedEntities() {
$referenced_entities = array();
// @todo Remove when all entities are converted to EntityNG.
if (!$this->getPropertyDefinitions()) {
return $referenced_entities;
}
// Gather a list of referenced entities.
foreach ($this->getProperties() as $name => $definition) {
$field_items = $this->get($name);
foreach ($field_items as $offset => $field_item) {
if ($field_item instanceof EntityReferenceItem && $entity = $field_item->entity) {
$referenced_entities[] = $entity;
}
}
}
return $referenced_entities;
}
/**
* {@inheritdoc}
*/
public function changed() {
$referenced_entity_ids = array(
$this->entityType() => array($this->id() => TRUE),
);
foreach ($this->referencedEntities() as $referenced_entity) {
$referenced_entity_ids[$referenced_entity->entityType()][$referenced_entity->id()] = TRUE;
}
foreach ($referenced_entity_ids as $entity_type => $entity_ids) {
if (\Drupal::entityManager()->hasController($entity_type, 'render')) {
\Drupal::entityManager()->getRenderController($entity_type)->resetCache(array_keys($entity_ids));
}
}
}
}
......@@ -325,4 +325,17 @@ public function initTranslation($langcode);
*/
public static function baseFieldDefinitions($entity_type);
/**
* Returns a list of entities referenced by this entity.
*
* @return array
* An array of entities.
*/
public function referencedEntities();
/**
* Acts on an entity after it was saved or deleted.
*/
public function changed();
}
......@@ -6,8 +6,8 @@
*/
namespace Drupal\Core\Entity;
use Drupal\entity\Entity\EntityDisplay;
use Drupal\entity\Entity\EntityDisplay;
use Drupal\Core\Language\Language;
/**
......@@ -22,8 +22,37 @@ class EntityRenderController implements EntityRenderControllerInterface {
*/
protected $entityType;
/**
* The entity info array.
*
* @var array
*
* @see entity_get_info()
*/
protected $entityInfo;
/**
* An array of view mode info for the type of entities for which this
* controller is instantiated.
*
* @var array
*/
protected $viewModesInfo;
/**
* The cache bin used to store the render cache.
*
* @todo Defaults to 'cache' for now, until http://drupal.org/node/1194136 is
* fixed.
*
* @var string
*/
protected $cacheBin = 'cache';
public function __construct($entity_type) {
$this->entityType = $entity_type;
$this->entityInfo = entity_get_info($entity_type);
$this->viewModesInfo = entity_get_view_modes($entity_type);
}
/**
......@@ -80,6 +109,23 @@ protected function getBuildDefaults(EntityInterface $entity, $view_mode, $langco
'#view_mode' => $view_mode,
'#langcode' => $langcode,
);
// Cache the rendered output if permitted by the view mode and global entity
// type configuration. The isset() checks below are necessary because
// 'default' is not an actual view mode.
$view_mode_is_cacheable = !isset($this->viewModesInfo[$view_mode]) || (isset($this->viewModesInfo[$view_mode]) && $this->viewModesInfo[$view_mode]['cache']);
if ($view_mode_is_cacheable && !$entity->isNew() && !isset($entity->in_preview) && $this->entityInfo['render_cache']) {
$return['#cache'] = array(
'keys' => array('entity_view', $this->entityType, $entity->id(), $view_mode),
'granularity' => DRUPAL_CACHE_PER_ROLE,
'bin' => $this->cacheBin,
'tags' => array(
$this->entityType . '_view' => TRUE,
$this->entityType => array($entity->id()),
),
);
}
return $return;
}
......@@ -182,4 +228,20 @@ public function viewMultiple(array $entities = array(), $view_mode = 'full', $la
return $build;
}
/**
* {@inheritdoc}
*/
public function resetCache(array $ids = NULL) {
if (isset($ids)) {
$tags = array();
foreach ($ids as $entity_id) {
$tags[$this->entityType][$entity_id] = $entity_id;
}
\Drupal::cache($this->cacheBin)->deleteTags($tags);
}
else {
\Drupal::cache($this->cacheBin)->deleteTags(array($this->entityType . '_view' => TRUE));
}
}
}
......@@ -75,4 +75,14 @@ public function view(EntityInterface $entity, $view_mode = 'full', $langcode = N
* be available for loading.
*/
public function viewMultiple(array $entities = array(), $view_mode = 'full', $langcode = NULL);
/**
* Resets the entity render cache.
*
* @param array|null $ids
* (optional) If specified, the cache is reset for the given entity IDs
* only.
*/
public function resetCache(array $ids = NULL);
}
......@@ -20,7 +20,7 @@ class IntegrationTest extends ViewUnitTestBase {
*
* @var array
*/
public static $modules = array('aggregator', 'aggregator_test_views', 'system', 'field');
public static $modules = array('aggregator', 'aggregator_test_views', 'system', 'entity', 'field');
/**
* Views used by this test.
......
id: custom_block.full
label: Full
status: '0'
cache: '1'
targetEntityType: custom_block
......@@ -62,4 +62,9 @@ public function viewMultiple(array $entities = array(), $view_mode = 'full', $la
return $build;
}
/**
* {@inheritdoc}
*/
public function resetCache(array $ids = NULL) { }
}
id: node.print
label: Print
status: '0'
cache: '1'
targetEntityType: node
id: comment.full
label: Full comment
status: '0'
cache: '1'
targetEntityType: comment
......@@ -219,6 +219,7 @@ public function getReplyForm(Request $request, NodeInterface $node, $pid = NULL)
elseif ($account->hasPermission('access content')) {
// Display the node.
$build['comment_node'] = $this->entityManager()->getRenderController('node')->view($node);
unset($build['comment_node']['#cache']);
}
}
else {
......
......@@ -36,6 +36,7 @@
* uri_callback = "comment_uri",
* fieldable = TRUE,
* translatable = TRUE,
* render_cache = FALSE,
* route_base_path = "admin/structure/types/manage/{bundle}/comment",
* bundle_prefix = "comment_node_",
* entity_keys = {
......
......@@ -7,19 +7,19 @@
namespace Drupal\editor\Tests;
use Drupal\simpletest\DrupalUnitTestBase;
use Drupal\system\Tests\Entity\EntityUnitTestBase;
/**
* Unit tests for editor.module's entity hooks to track file usage.
*/
class EditorFileUsageTest extends DrupalUnitTestBase {
class EditorFileUsageTest extends EntityUnitTestBase {
/**
* Modules to enable.
*
* @var array
*/
public static $modules = array('system', 'editor', 'editor_test', 'filter', 'node', 'entity', 'field', 'text', 'field_sql_storage', 'file');
public static $modules = array('editor', 'editor_test', 'node', 'file');
public static function getInfo() {
return array(
......@@ -31,13 +31,8 @@ public static function getInfo() {
function setUp() {
parent::setUp();
$this->installSchema('system', 'url_alias');
$this->installSchema('node', 'node');
$this->installSchema('node', 'node_access');
$this->installSchema('node', 'node_field_data');
$this->installSchema('node', 'node_field_revision');
$this->installSchema('file', 'file_managed');
$this->installSchema('file', 'file_usage');
$this->installSchema('node', array('node', 'node_access', 'node_field_data', 'node_field_revision'));
$this->installSchema('file', array('file_managed', 'file_usage'));
// Add text formats.
$filtered_html_format = entity_create('filter_format', array(
......@@ -71,13 +66,15 @@ function testEditorEntityHooks() {
$this->assertIdentical(array(), file_usage()->listUsage($image), 'The image has zero usages.');
// Test editor_entity_insert(): increment.
$this->createUser();
$node = entity_create('node', array(
'type' => 'page',
'title' => 'test',
'body' => array(
'value' => '<p>Hello, world!</p><img src="awesome-llama.jpg" data-editor-file-uuid="' . $image->uuid() . '" />',
'format' => 'filtered_html',
)
),
'uid' => 1,
));
$node->save();
$this->assertIdentical(array('editor' => array('node' => array(1 => '1'))), file_usage()->listUsage($image), 'The image has 1 usage.');
......
......@@ -118,6 +118,20 @@ public function id() {
return $this->targetEntityType . '.' . $this->bundle . '.' . $this->mode;
}
/**
* {@inheritdoc}
*/
public function save() {
$return = parent::save();
// Reset the render cache for the target entity type.
if (\Drupal::entityManager()->hasController($this->targetEntityType, 'render')) {
\Drupal::entityManager()->getRenderController($this->targetEntityType)->resetCache();
}
return $return;
}
/**
* {@inheritdoc}
*/
......
......@@ -57,6 +57,13 @@ abstract class EntityDisplayModeBase extends ConfigEntityBase implements EntityD
*/
public $status = TRUE;
/**
* Whether or not the rendered output of this view mode is cached by default.
*
* @var bool
*/
public $cache = TRUE;
/**
* {@inheritdoc}
*/
......
......@@ -96,8 +96,21 @@ public function view(FieldInterface $items) {
'#object' => $entity,
'#items' => $items->getValue(TRUE),
'#formatter' => $this->getPluginId(),
'#cache' => array('tags' => array())
);
// Gather cache tags from reference fields.
foreach ($items as $item) {
if (isset($item->format)) {
$info['#cache']['tags']['filter_format'] = $item->format;
}
if (isset($item->entity)) {
$info['#cache']['tags'][$item->entity->entityType()][] = $item->entity->id();
$info['#cache']['tags'][$item->entity->entityType() . '_view'] = TRUE;
}
}
$addition[$field_name] = array_merge($info, $elements);
}
......
......@@ -35,8 +35,9 @@ abstract class FieldUnitTestBase extends DrupalUnitTestBase {
*/
function setUp() {
parent::setUp();
$this->installSchema('system', array('sequences', 'variable', 'config_snapshot'));
$this->installSchema('entity_test', 'entity_test');
$this->installSchema('system', array('sequences', 'variable', 'config_snapshot'));
$this->installSchema('user', array('users', 'users_roles'));
// Set default storage backend and configure the theme system.
$this->installConfig(array('field', 'system'));
......
......@@ -31,7 +31,6 @@ function setUp() {
parent::setUp();
$this->installConfig(array('system', 'filter'));
$this->installSchema('user', array('users_roles'));
// Create Filtered HTML format.
$filtered_html_format = entity_create('filter_format', array(
......
id: node.full
label: Full content
status: '0'
cache: '1'
targetEntityType: node
id: node.rss
label: RSS
status: '0'
cache: '1'
targetEntityType: node
id: node.teaser
label: Teaser
status: '1'
cache: '1'
targetEntityType: node
......@@ -40,6 +40,7 @@
* uri_callback = "node_uri",
* fieldable = TRUE,
* translatable = TRUE,
* render_cache = FALSE,
* entity_keys = {
* "id" = "nid",
* "revision" = "vid",
......
......@@ -85,6 +85,10 @@ protected function alterBuild(array &$build, EntityInterface $entity, EntityDisp
if ($entity->id()) {
$build['#contextual_links']['node'] = array('node', array($entity->id()));
}
// The node 'submitted' info is not rendered in a standard way (renderable
// array) so we have to add a cache tag manually.
$build['#cache']['tags']['user'][] = $entity->uid;
}
}
......@@ -7,14 +7,14 @@
namespace Drupal\node\Tests\Condition;
use Drupal\simpletest\DrupalUnitTestBase;
use Drupal\system\Tests\Entity\EntityUnitTestBase;
/**
* Tests the node conditions.
*/
class NodeConditionTest extends DrupalUnitTestBase {
class NodeConditionTest extends EntityUnitTestBase {
public static $modules = array('system', 'node', 'field');
public static $modules = array('node');
public static function getInfo() {
return array(
......@@ -24,11 +24,9 @@ public static function getInfo() {
);
}
protected function setUp() {
public function setUp() {
parent::setUp();
$this->installSchema('node', 'node');
$this->installSchema('node', 'node_field_data');
$this->installSchema('node', 'node_field_revision');
$this->installSchema('node', array('node', 'node_field_data', 'node_field_revision'));
}
/**
......@@ -36,13 +34,14 @@ protected function setUp() {
*/
function testConditions() {
$manager = $this->container->get('plugin.manager.condition', $this->container->get('container.namespaces'));
$this->createUser();
// Get some nodes of various types to check against.
$page = entity_create('node', array('type' => 'page', 'title' => $this->randomName()));
$page = entity_create('node', array('type' => 'page', 'title' => $this->randomName(), 'uid' => 1));
$page->save();
$article = entity_create('node', array('type' => 'article', 'title' => $this->randomName()));
$article = entity_create('node', array('type' => 'article', 'title' => $this->randomName(), 'uid' => 1));
$article->save();
$test = entity_create('node', array('type' => 'test', 'title' => $this->randomName()));
$test = entity_create('node', array('type' => 'test', 'title' => $this->randomName(), 'uid' => 1));
$test->save();
// Grab the node type condition and configure it to check against node type
......
......@@ -19,7 +19,7 @@ class NodeLastChangedTest extends DrupalUnitTestBase {
*
* @var array
*/
public static $modules = array('node', 'field');
public static $modules = array('entity', 'user', 'node', 'field');
public static function getInfo() {
return array(
......@@ -34,6 +34,7 @@ public function setUp() {
$this->installSchema('node', 'node');
$this->installSchema('node', 'node_field_data');
$this->installSchema('node', 'node_field_revision');
$this->installSchema('user', array('users'));
}
/**
......
......@@ -7,19 +7,19 @@
namespace Drupal\node\Tests;
use Drupal\simpletest\DrupalUnitTestBase;
use Drupal\system\Tests\Entity\EntityUnitTestBase;
/**
* Tests node validation constraints.
*/
class NodeValidationTest extends DrupalUnitTestBase {
class NodeValidationTest extends EntityUnitTestBase {
/**
* Modules to enable.
*
* @var array
*/
public static $modules = array('node', 'entity', 'field', 'text', 'field_sql_storage', 'filter');
public static $modules = array('node');
public static function getInfo() {
return array(
......@@ -34,9 +34,7 @@ public static function getInfo() {
*/
public function setUp() {
parent::setUp();
$this->installSchema('node', 'node');
$this->installSchema('node', 'node_field_data');
$this->installSchema('node', 'node_field_revision');
$this->installSchema('node', array('node', 'node_field_data', 'node_field_revision'));
// Create a node type for testing.
$type = entity_create('node_type', array('type' => 'page', 'name' => 'page'));
......@@ -47,7 +45,8 @@ public function setUp() {
* Tests the node validation constraints.
*/
public function testValidation() {
$node = entity_create('node', array('type' => 'page', 'title' => 'test'));
$this->createUser();
$node = entity_create('node', array('type' => 'page', 'title' => 'test', 'uid' => 1));
$violations = $node->validate();
$this->assertEqual(count($violations), 0, 'No violations when validating a default node.');
......
......@@ -585,6 +585,8 @@ function node_show(EntityInterface $node, $message = FALSE) {
if ($message) {
$page['#title'] = t('Revision of %title from %date', array('%title' => $node->label(), '%date' => format_date($node->getRevisionCreationTime())));
// Don't use the render cache when a revision is displayed.
unset($page['nodes'][<