Unverified Commit d764daae authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3092430 by quietone, shrutidkadam, RdeBoer, bgprior, danflanagan8:... 

Issue #3092430 by quietone, shrutidkadam, RdeBoer, bgprior, danflanagan8: Ensure SearchPlugin has a configuration array

(cherry picked from commit 331e284e)
parent 00e48f5b

core/modules/search/migrations/d7_search_page.yml

+3 −0
Original line number Diff line number Diff line
@@ -41,6 +41,9 @@ process: 
        - module

        - 'constants/suffix'

  path: module

  configuration:

    plugin: default_value

    default_value: [ ]

  'configuration/rankings':

    plugin: search_configuration_rankings

destination:

core/modules/search/migrations/search_page.yml

+3 −0
Original line number Diff line number Diff line
@@ -21,6 +21,9 @@ process: 
  id: 'constants/id'

  path: 'constants/path'

  plugin: 'constants/plugin'

  configuration:

    plugin: default_value

    default_value: [ ]

  'configuration/rankings':

    plugin: search_configuration_rankings

destination:

core/modules/search/tests/src/Kernel/Migrate/d6/MigrateSearchPageTest.php

+14 −0
Original line number Diff line number Diff line
@@ -60,6 +60,20 @@ public function testSearchPage() { 


    $configuration = SearchPage::load($id)->getPlugin()->getConfiguration();

    $this->assertSame(4, $configuration['rankings']['comments']);



    // Test that a configurable search without a configuration imports. Do this

    // by removing the node rankings from the source database.

    Database::getConnection('default', 'migrate')

      ->delete('variable')

      ->condition('name', 'node_rank_%', 'LIKE')

      ->execute();



    $migration = $this->getMigration('search_page');

    $migration->getIdMap()->prepareUpdate();

    $this->executeMigration($migration);



    $configuration = SearchPage::load($id)->getPlugin()->getConfiguration();

    $this->assertSame([], $configuration['rankings']);

  }



}

core/modules/search/tests/src/Kernel/Migrate/d7/MigrateSearchPageTest.php

+13 −0
Original line number Diff line number Diff line
@@ -79,6 +79,19 @@ public function testSearchPage() { 
    $this->executeMigration($migration);

    $configuration['rankings']['comments'] = 4;

    $this->assertEntity('node_search', 'node', TRUE, $configuration);



    // Test that a configurable search without a configuration imports. Do this

    // by removing the node rankings from the source database.

    Database::getConnection('default', 'migrate')

      ->delete('variable')

      ->condition('name', 'node_rank_%', 'LIKE')

      ->execute();



    $migration = $this->getMigration('d7_search_page');

    $migration->getIdMap()->prepareUpdate();

    $this->executeMigration($migration);

    $configuration = ['rankings' => []];

    $this->assertEntity('node_search', 'node', TRUE, $configuration);

  }



  /**