Issue #3478504 by andypost: upgrade phpstan to 1.11.10 for 10.4.x (8e8e0f4c) · Commits · project / drupal

composer.json

+2 −2

Original line number	Diff line number	Diff line
		@@ -23,7 +23,7 @@
		"justinrainbow/json-schema": "^5.2",
		"lullabot/mink-selenium2-driver": "^1.7",
		"lullabot/php-webdriver": "^2.0.4",
		"mglaman/phpstan-drupal": "^1.2.10",
		"mglaman/phpstan-drupal": "^1.2.11",
		"micheh/phpcs-gitlab": "^1.1",
		"mikey179/vfsstream": "^1.6.11",
		"open-telemetry/exporter-otlp": "^1",
		@@ -31,7 +31,7 @@
		"php-http/guzzle7-adapter": "^1.0",
		"phpspec/prophecy-phpunit": "^2",
		"phpstan/extension-installer": "^1.1",
		"phpstan/phpstan": "^1.11.0",
		"phpstan/phpstan": "^1.11.10",
		"phpstan/phpstan-phpunit": "^1.3.16",
		"phpunit/phpunit": "^9.6.13",
		"symfony/browser-kit": "^6.4",

composer.lock

+6 −6

Original line number	Diff line number	Diff line
		@@ -4,7 +4,7 @@
		"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
		"This file is @generated automatically"
		],
		"content-hash": "7f3c203e5297306f9277da08961993f2",
		"content-hash": "acd1176decc34fd5c7cae5910f5d49df",
		"packages": [
		{
		"name": "asm89/stack-cors",
		@@ -7098,16 +7098,16 @@
		},
		{
		"name": "phpstan/phpstan",
		"version": "1.11.0",
		"version": "1.11.10",
		"source": {
		"type": "git",
		"url": "https://github.com/phpstan/phpstan.git",
		"reference": "666cb1703742cea9cc80fee631f0940e1592fa6e"
		"reference": "640410b32995914bde3eed26fa89552f9c2c082f"
		},
		"dist": {
		"type": "zip",
		"url": "https://api.github.com/repos/phpstan/phpstan/zipball/666cb1703742cea9cc80fee631f0940e1592fa6e",
		"reference": "666cb1703742cea9cc80fee631f0940e1592fa6e",
		"url": "https://api.github.com/repos/phpstan/phpstan/zipball/640410b32995914bde3eed26fa89552f9c2c082f",
		"reference": "640410b32995914bde3eed26fa89552f9c2c082f",
		"shasum": ""
		},
		"require": {
		@@ -7152,7 +7152,7 @@
		"type": "github"
		}
		],
		"time": "2024-05-13T06:02:22+00:00"
		"time": "2024-08-08T09:02:50+00:00"
		},
		{
		"name": "phpstan/phpstan-deprecation-rules",

composer/Metapackage/DevDependencies/composer.json

+2 −2

Original line number	Diff line number	Diff line
		@@ -15,7 +15,7 @@
		"justinrainbow/json-schema": "^5.2",
		"lullabot/mink-selenium2-driver": "^1.7",
		"lullabot/php-webdriver": "^2.0.4",
		"mglaman/phpstan-drupal": "^1.2.10",
		"mglaman/phpstan-drupal": "^1.2.11",
		"micheh/phpcs-gitlab": "^1.1",
		"mikey179/vfsstream": "^1.6.11",
		"open-telemetry/exporter-otlp": "^1",
		@@ -23,7 +23,7 @@
		"php-http/guzzle7-adapter": "^1.0",
		"phpspec/prophecy-phpunit": "^2",
		"phpstan/extension-installer": "^1.1",
		"phpstan/phpstan": "^1.11.0",
		"phpstan/phpstan": "^1.11.10",
		"phpstan/phpstan-phpunit": "^1.3.16",
		"phpunit/phpunit": "^9.6.13",
		"symfony/browser-kit": "^6.4",

composer/Metapackage/PinnedDevDependencies/composer.json

+1 −1

Original line number	Diff line number	Diff line
		@@ -49,7 +49,7 @@
		"phpspec/prophecy-phpunit": "v2.2.0",
		"phpstan/extension-installer": "1.3.1",
		"phpstan/phpdoc-parser": "1.29.0",
		"phpstan/phpstan": "1.11.0",
		"phpstan/phpstan": "1.11.10",
		"phpstan/phpstan-deprecation-rules": "1.2.0",
		"phpstan/phpstan-phpunit": "1.4.0",
		"phpunit/php-code-coverage": "9.2.32",

core/.phpstan-baseline.php

+14 −14

Original line number	Diff line number	Diff line
		@@ -42,7 +42,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Function install_download_translation\$\$ should return string but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/includes/install.core.inc',
		];
		$ignoreErrors[] = [
		@@ -965,7 +965,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\block_content\\\\BlockContentForm\\:\\:save\$\$ should return int but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/block_content/src/BlockContentForm.php',
		];
		$ignoreErrors[] = [
		@@ -1001,7 +1001,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\book\\\\Form\\\\BookOutlineForm\\:\\:save\$\$ should return int but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/book/src/Form/BookOutlineForm.php',
		];
		$ignoreErrors[] = [
		@@ -1079,7 +1079,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\contact\\\\MessageForm\\:\\:save\$\$ should return int but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/contact/src/MessageForm.php',
		];
		$ignoreErrors[] = [
		@@ -1253,7 +1253,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\file\\\\Plugin\\\\Field\\\\FieldType\\\\FileFieldItemList\\:\\:postSave\$\$ should return bool but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/file/src/Plugin/Field/FieldType/FileFieldItemList.php',
		];
		$ignoreErrors[] = [
		@@ -1457,7 +1457,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\locale\\\\LocaleDefaultConfigStorage\\:\\:read\$\$ should return array but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/locale/src/LocaleDefaultConfigStorage.php',
		];
		$ignoreErrors[] = [
		@@ -1769,13 +1769,13 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\node\\\\ConfigTranslation\\\\NodeTypeMapper\\:\\:setEntity\$\$ should return bool but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/node/src/ConfigTranslation/NodeTypeMapper.php',
		];
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\node\\\\NodeForm\\:\\:save\$\$ should return int but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/node/src/NodeForm.php',
		];
		$ignoreErrors[] = [
		@@ -1859,7 +1859,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\path\\\\Plugin\\\\Field\\\\FieldType\\\\PathItem\\:\\:postSave\$\$ should return bool but return statement is missing\\.$#',
		'count' => 1,
		'count' => 3,
		'path' => __DIR__ . '/modules/path/src/Plugin/Field/FieldType/PathItem.php',
		];
		$ignoreErrors[] = [
		@@ -1899,7 +1899,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\responsive_image\\\\ResponsiveImageStyleForm\\:\\:save\$\$ should return int but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/responsive_image/src/ResponsiveImageStyleForm.php',
		];
		$ignoreErrors[] = [
		@@ -2138,7 +2138,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\taxonomy\\\\TermForm\\:\\:validateForm\$\$ should return Drupal\\\\Core\\\\Entity\\\\ContentEntityInterface but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/taxonomy/src/TermForm.php',
		];
		$ignoreErrors[] = [
		@@ -2210,7 +2210,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\user\\\\RegisterForm\\:\\:save\$\$ should return int but return statement is missing\\.$#',
		'count' => 1,
		'count' => 4,
		'path' => __DIR__ . '/modules/user/src/RegisterForm.php',
		];
		$ignoreErrors[] = [
		@@ -2570,7 +2570,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\views_ui\\\\ViewUI\\:\\:set\$\$ should return \\$this\$Drupal\\\\views_ui\\\\ViewUI\$ but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/views_ui/src/ViewUI.php',
		];
		$ignoreErrors[] = [
		@@ -2624,7 +2624,7 @@
		$ignoreErrors[] = [
		// identifier: return.missing
		'message' => '#^Method Drupal\\\\workspaces\\\\Form\\\\WorkspaceForm\\:\\:save\$\$ should return int but return statement is missing\\.$#',
		'count' => 1,
		'count' => 2,
		'path' => __DIR__ . '/modules/workspaces/src/Form/WorkspaceForm.php',
		];
		$ignoreErrors[] = [