Issue #3307695 by smustgrave, Shubham Chandra, andypost, Amber Himes Matz,...

Issue #3307695 by smustgrave, Shubham Chandra, andypost, Amber Himes Matz, Gábor Hojtsy: Update sentence-embedded internal links in content_moderation, core.content_structure, search.overview help topics to use help_route_link function

core/modules/help_topics/help_topics/content_moderation.changing_states.html.twig

@@ -7,15 +7,17 @@ related:
 ---
 {% set workflows_overview_topic = render_var(help_topic_link('workflows.overview')) %}
 {% set content_structure_topic = render_var(help_topic_link('core.content_structure')) %}
-{% set content_moderation_permissions = render_var(url('user.admin_permissions.module', {'modules': 'content_moderation'})) %}
-{% set content = render_var(url('system.admin_content')) %}
+{% set content_moderation_permissions_link_text %}{% trans %}Content Moderation{% endtrans %}{% endset %}
+{% set content_moderation_permissions_link = render_var(help_route_link(content_moderation_permissions_link_text, 'user.admin_permissions', {}, {'fragment': 'module-content_moderation'})) %}
+{% set content_link_text %}{% trans %}Content{% endtrans %}{% endset %}
+{% set content_link = render_var(help_route_link(content_link_text, 'system.admin_content')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Change the workflow state of a particular entity. See {{ workflows_overview_topic }} for an overview of workflows, and {{ content_structure_topic }} for an overview of content entities.{% endtrans %}</p>
 <h2>{% trans %}Who can change workflow states?{% endtrans %}</h2>
-<p>{% trans %}Users with the <a href="{{ content_moderation_permissions }}">content moderation permissions</a> can change workflow states. There are separate permissions for each transition.{% endtrans %}</p>
+<p>{% trans %}Users with <em>content moderation permissions</em> can change workflow states. There are separate permissions for each transition. See Permissions &gt; <em>{{ content_moderation_permissions_link }}</em> to configure content moderation permissions.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}Find the entity that you want to moderate in either the content moderation view page, if you created one, or the appropriate administrative page for managing that type of entity (such as the <a href="{{ content }}">Content</a> administration page for content items).{% endtrans %}</li>
+  <li>{% trans %}Find the entity that you want to moderate in either the content moderation view page, if you created one, or the appropriate administrative page for managing that type of entity (such as the administration page for content items; see {{ content_link }}).{% endtrans %}</li>
   <li>{% trans %}Click <em>Edit</em> to edit the entity.{% endtrans %}</li>
   <li>{% trans %}At the bottom of the page, select the new workflow state under <em>Change to:</em> and click <em>Save</em>.{% endtrans %}</li>
 </ol>

core/modules/help_topics/help_topics/content_moderation.configuring_workflows.html.twig

@@ -10,13 +10,16 @@ related:
 {% set user_overview_topic = render_var(help_topic_link('user.overview')) %}
 {% set user_permissions_topic = render_var(help_topic_link('user.permissions')) %}
 {% set workflows_overview_topic = render_var(help_topic_link('workflows.overview')) %}
-{% set content_moderation_permissions = render_var(url('user.admin_permissions.module', {'modules': 'content_moderation'})) %}
-{% set workflows_permissions = render_var(url('user.admin_permissions.module', {'modules': 'workflows'})) %}
-{% set workflows_url = render_var(url('entity.workflow.collection')) %}
+{% set content_moderation_permissions_link_text %}{% trans %}Content Moderation{% endtrans %}{% endset %}
+{% set content_moderation_permissions_link = render_var(help_route_link(content_moderation_permissions_link_text, 'user.admin_permissions', {}, {'fragment': 'module-content_moderation'})) %}
+{% set workflows_permissions_link_text %}{% trans %}Administer workflows{% endtrans %}{% endset %}
+{% set workflows_permissions_link = render_var(help_route_link(workflows_permissions_link_text, 'user.admin_permissions', {}, {'fragment': 'module-workflows'})) %}
+{% set workflows_link_text %}{% trans %}Workflows{% endtrans %}{% endset %}
+{% set workflows_link = render_var(help_route_link(workflows_link_text, 'entity.workflow.collection')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Create or edit a workflow with various workflow states (for example <em>Concept</em>, <em>Archived</em>, etc.) for moderating content. See {{ workflows_overview_topic }} for more information on workflows.{% endtrans %}</p>
 <h2>{% trans %}Who can configure a workflow?{% endtrans %}</h2>
-<p>{% trans %}Users with the <em><a href="{{ workflows_permissions }}">Administer workflows</a></em> permission (typically administrators) can configure workflows.{% endtrans %}</p>
+<p>{% trans %}Users with <em>workflows permissions</em> (typically administrators) can configure workflows. See Permissions &gt; <em>{{ workflows_permissions_link }}</em> to configure workflows permissions.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
   <li>{% trans %}Make a plan for the new workflow:{% endtrans %}
@@ -35,7 +38,7 @@ related:
       <li>{% trans %}Decide which <em>entity types</em> and subtypes the workflow should apply to. Only entity types that support revisions are possible to define workflows for. See {{ content_structure_topic }} for more information on content entities and fields.{% endtrans %}</li>
     </ul>
   </li>
-  <li>{% trans %}To implement your plan, in the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Workflow</em> &gt; <a href="{{ workflows_url}}"><em>Workflows</em></a>. A list of workflows is shown, including the default workflow <em>Editorial</em> that you can adapt.{% endtrans %}</li>
+  <li>{% trans %}To implement your plan, in the <em>Manage</em> administrative menu, navigate to <em>Configuration</em> &gt; <em>Workflow</em> &gt; <em>{{ workflows_link }}</em>. A list of workflows is shown, including the default workflow <em>Editorial</em> that you can adapt.{% endtrans %}</li>
   <li>{% trans %}Click <em>Add workflow</em>.{% endtrans %}</li>
   <li>{% trans %}Enter a name in the <em>Label</em> field, select <em>Content moderation</em> from the <em>Workflow type</em> field, and click <em>Save</em>.{% endtrans %}</li>
   <li>{% trans %}Verify that the <em>States</em> list matches your planned states. You can add missing states by clicking <em>Add a new state</em>. You can edit or delete states by clicking <em>Edit</em> or <em>Delete</em> under <em>Operations</em> (if the <em>Delete</em> option is not available, you will first need to delete any <em>Transitions</em> to or from this state).{% endtrans %}</li>
@@ -45,6 +48,6 @@ related:
   <li>{% trans %}Click <em>Save</em>.{% endtrans %}</li>
   <li>{% trans %}Under <em>Workflow settings</em>, select the <em>Default moderation state</em> for new content.{% endtrans %}</li>
   <li>{% trans %}Click <em>Save</em> to save your workflow.{% endtrans %}</li>
-  <li>{% trans %}Follow the steps in {{ user_permissions_topic }} to assign permissions for each transition to roles. The permissions are listed under the <em><a href="{{ content_moderation_permissions }}">Content Moderation</a></em> section; there is one permission for each transition in each workflow.{% endtrans %}</li>
+  <li>{% trans %}Follow the steps in {{ user_permissions_topic }} to assign permissions for each transition to roles. The permissions are listed under the <em>{{ content_moderation_permissions_link }}</em> section; there is one permission for each transition in each workflow.{% endtrans %}</li>
   <li>{% trans %}Optionally (recommended), create a view for your custom workflow, to provide a page for content editors to see what content needs to be moderated. You can do this if the Views UI module is installed, by following the steps in the related <em>Creating a new view</em> topic listed below under <em>Related topics</em>. When creating the view, under <em>View settings</em> &gt; <em>Show</em>, select the revision data type you configured the workflow for, and be sure to display the <em>Workflow State</em> field in your view.{% endtrans %}</li>
 </ol>

core/modules/help_topics/help_topics/core.content_structure.html.twig

@@ -2,7 +2,8 @@
 label: 'Managing content structure'
 top_level: true
 ---
-{% set help_url = render_var(url('help.main')) %}
+{% set help_link_text %}{% trans %}Help{% endtrans %}{% endset %}
+{% set help_link = render_var(help_route_link(help_link_text, 'help.main')) %}
 <h2>{% trans %}What types of data does a site have?{% endtrans %}</h2>
 <p>{% trans %}There are four main types of data. <em>Content</em> is the information (text, images, etc.) meant to be displayed to website visitors. <em>Configuration</em> is data that defines how the content is displayed; some configuration (such as field labels) may also be visible to site visitors. <em>State</em> is temporary data about the state of your site, such as the last time the system <em>cron</em> jobs ran. <em>Session</em> is a subset of State information, related to users' interactions with the site, such as site cookies and whether or not they are logged in.{% endtrans %}</p>
 <h2>{% trans %}What is a content entity?{% endtrans %}</h2>
@@ -41,7 +42,7 @@ top_level: true
   <li>{% trans %}The core Layout Builder module provides a more flexible user interface for configuring the display of entities.{% endtrans %}</li>
   <li>{% trans %}The core Filter, Responsive Image, and Path modules provide settings and display options for entities and fields.{% endtrans %}</li>
 </ul>
-<p>{% trans %}Depending on the core and contributed modules that you currently have installed on your site, the related topics below, and other topics listed on the main <a href="{{ help_url }}">Help page</a>, will help you with tasks related to content structure.{% endtrans %}</p>
+<p>{% trans %}Depending on the core and contributed modules that you currently have installed on your site, the related topics below and other topics listed on the main help page (see {{ help_link }}) will help you with tasks related to content structure.{% endtrans %}</p>
 <h2>{% trans %}Additional resources{% endtrans %}</h2>
 <ul>
   <li>{% trans %}<a href="https://www.drupal.org/docs/user_guide/en/understanding-data.html">Concept: Types of Data topic in the User Guide</a>{% endtrans %}</li>

core/modules/help_topics/help_topics/search.overview.html.twig

@@ -5,11 +5,12 @@ related:
   - user.permissions
   - block.place
 ---
-{% set search_url = render_var(url('search.view')) %}
+{% set search_link_text %}{% trans %}Search{% endtrans %}{% endset %}
+{% set search_link = render_var(help_route_link(search_link_text, 'search.view')) %}
 {% set user_overview_topic = render_var(help_topic_link('user.overview')) %}
 <h2>{% trans %}What are search pages?{% endtrans %}</h2>
 <p>{% trans %}The core Search module organizes site search into <em>pages</em>. Each page allows users to search a particular type of content with a particular configuration. The configuration includes specifying a URL that starts with <em>search</em>, a name for the page, and additional options for some search page types.{% endtrans %}</p>
-<p>{% trans %}When users visit the main <a href="{{ search_url }}">Search page</a>, they will see the configured search pages that they have access to. Each search page has a search form on it, and the page will display search results after the user enters keywords into the form and clicks the search button.{% endtrans %}</p>
+<p>{% trans %}When users visit the main search page (see {{ search_link }}), they will see the configured search pages that they have access to. Each search page has a search form on it, and the page will display search results after the user enters keywords into the form and clicks the search button.{% endtrans %}</p>
 <h2>{% trans %}What modules provide site search?{% endtrans %}</h2>
 <p>{% trans %}The core Search module provides the ability to configure search pages; search page types are provided by both core and contributed modules. The core modules that provide search page types are:{% endtrans %}</p>
 <ul>