Issue #3108851 by JeroenT, Berdir, Wim Leers: Remove deprecated node.module...

Issue #3108851 by JeroenT, Berdir, Wim Leers: Remove deprecated node.module action plugins and leftovers

core/modules/node/config/schema/node.schema.yml

@@ -63,30 +63,6 @@ action.configuration.node_promote_action:
   type: action_configuration_default
   label: 'Promote selected content from front page configuration'
 
-# @deprecated in Drupal 8.5.x, to be removed before Drupal 9.0.0.
-# @see https://www.drupal.org/node/2919303
-action.configuration.node_publish_action:
-  type: action_configuration_default
-  label: 'Publish selected content configuration'
-
-# @deprecated in Drupal 8.5.x, to be removed before Drupal 9.0.0.
-# @see https://www.drupal.org/node/2919303
-action.configuration.node_unpublish_action:
-  type: action_configuration_default
-  label: 'Unpublish selected content configuration'
-
-# @deprecated in Drupal 8.5.x, to be removed before Drupal 9.0.0.
-# @see https://www.drupal.org/node/2919303
-action.configuration.node_save_action:
-  type: action_configuration_default
-  label: 'Save content configuration'
-
-# @deprecated in Drupal 8.6.x, to be removed before Drupal 9.0.0.
-# @see https://www.drupal.org/node/2934349
-action.configuration.node_delete_action:
-  type: action_configuration_default
-  label: 'Delete content configuration'
-
 action.configuration.node_make_sticky_action:
   type: action_configuration_default
   label: 'Make selected content sticky configuration'

core/modules/node/src/NodeAccessControlHandler.php

@@ -156,14 +156,6 @@ public function acquireGrants(NodeInterface $node) {
     return $grants;
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function writeGrants(NodeInterface $node, $delete = TRUE) {
-    $grants = $this->acquireGrants($node);
-    $this->grantStorage->write($node, $grants, NULL, $delete);
-  }
-
   /**
    * {@inheritdoc}
    */

core/modules/node/src/NodeAccessControlHandlerInterface.php

@@ -28,27 +28,6 @@ interface NodeAccessControlHandlerInterface {
    */
   public function acquireGrants(NodeInterface $node);
 
-  /**
-   * Writes a list of grants to the database, deleting any previously saved ones.
-   *
-   * Modules that use node access can use this function when doing mass updates
-   * due to widespread permission changes.
-   *
-   * Note: Don't call this function directly from a contributed module. Call
-   * \Drupal\node\NodeAccessControlHandlerInterface::acquireGrants() instead.
-   *
-   * @param \Drupal\node\NodeInterface $node
-   *   The node whose grants are being written.
-   * @param $delete
-   *   (optional) If false, does not delete records. This is only for optimization
-   *   purposes, and assumes the caller has already performed a mass delete of
-   *   some form. Defaults to TRUE.
-   *
-   * @deprecated in drupal:8.0.0 and is removed from drupal:9.0.0.
-   *   Use \Drupal\node\NodeAccessControlHandlerInterface::acquireGrants().
-   */
-  public function writeGrants(NodeInterface $node, $delete = TRUE);
-
   /**
    * Creates the default node access grant entry on the grant storage.
    */

core/modules/node/src/Plugin/Action/DeleteNode.php

-<?php
-
-namespace Drupal\node\Plugin\Action;
-
-use Drupal\Core\Action\Plugin\Action\DeleteAction;
-use Drupal\Core\Entity\EntityTypeManagerInterface;
-use Drupal\Core\Session\AccountInterface;
-use Drupal\Core\TempStore\PrivateTempStoreFactory;
-
-/**
- * Redirects to a node deletion form.
- *
- * @deprecated in drupal:8.6.0 and is removed from drupal:9.0.0.
- *   Use \Drupal\Core\Action\Plugin\Action\DeleteAction instead.
- *
- * @see \Drupal\Core\Action\Plugin\Action\DeleteAction
- * @see https://www.drupal.org/node/2934349
- *
- * @Action(
- *   id = "node_delete_action",
- *   label = @Translation("Delete content")
- * )
- */
-class DeleteNode extends DeleteAction {
-
-  /**
-   * {@inheritdoc}
-   */
-  public function __construct(array $configuration, $plugin_id, $plugin_definition, EntityTypeManagerInterface $entity_type_manager, PrivateTempStoreFactory $temp_store_factory, AccountInterface $current_user) {
-    parent::__construct($configuration, $plugin_id, $plugin_definition, $entity_type_manager, $temp_store_factory, $current_user);
-    @trigger_error(__NAMESPACE__ . '\DeleteNode is deprecated in Drupal 8.6.x, will be removed before Drupal 9.0.0. Use \Drupal\Core\Action\Plugin\Action\DeleteAction instead. See https://www.drupal.org/node/2934349.', E_USER_DEPRECATED);
-  }
-
-}

core/modules/node/src/Plugin/Action/PublishNode.php

-<?php
-
-namespace Drupal\node\Plugin\Action;
-
-use Drupal\Core\Action\Plugin\Action\PublishAction;
-use Drupal\Core\Entity\EntityTypeManagerInterface;
-
-/**
- * Publishes a node.
- *
- * @deprecated in drupal:8.5.0 and is removed from drupal:9.0.0.
- *   Use \Drupal\Core\Action\Plugin\Action\PublishAction instead.
- *
- * @see \Drupal\Core\Action\Plugin\Action\PublishAction
- * @see https://www.drupal.org/node/2919303
- *
- * @Action(
- *   id = "node_publish_action",
- *   label = @Translation("Publish selected content"),
- *   type = "node"
- * )
- */
-class PublishNode extends PublishAction {
-
-  /**
-   * {@inheritdoc}
-   */
-  public function __construct($configuration, $plugin_id, $plugin_definition, EntityTypeManagerInterface $entity_type_manager) {
-    parent::__construct($configuration, $plugin_id, $plugin_definition, $entity_type_manager);
-    @trigger_error(__NAMESPACE__ . '\PublishNode is deprecated in Drupal 8.5.x, will be removed before Drupal 9.0.0. Use \Drupal\Core\Action\Plugin\Action\PublishAction instead. See https://www.drupal.org/node/2919303.', E_USER_DEPRECATED);
-  }
-
-}

core/modules/node/src/Plugin/Action/SaveNode.php

-<?php
-
-namespace Drupal\node\Plugin\Action;
-
-use Drupal\Component\Datetime\TimeInterface;
-use Drupal\Core\Action\Plugin\Action\SaveAction;
-use Drupal\Core\Entity\EntityTypeManagerInterface;
-
-/**
- * Provides an action that can save any entity.
- *
- * @deprecated in drupal:8.5.0 and is removed from drupal:9.0.0.
- *   Use \Drupal\Core\Action\Plugin\Action\SaveAction instead.
- *
- * @see \Drupal\Core\Action\Plugin\Action\SaveAction
- * @see https://www.drupal.org/node/2919303
- *
- * @Action(
- *   id = "node_save_action",
- *   label = @Translation("Save content"),
- *   type = "node"
- * )
- */
-class SaveNode extends SaveAction {
-
-  /**
-   * {@inheritdoc}
-   */
-  public function __construct($configuration, $plugin_id, $plugin_definition, EntityTypeManagerInterface $entity_type_manager, TimeInterface $time) {
-    parent::__construct($configuration, $plugin_id, $plugin_definition, $entity_type_manager, $time);
-    @trigger_error(__NAMESPACE__ . '\SaveNode is deprecated in Drupal 8.5.x, will be removed before Drupal 9.0.0. Use \Drupal\Core\Action\Plugin\Action\SaveAction instead. See https://www.drupal.org/node/2919303.', E_USER_DEPRECATED);
-  }
-
-}

core/modules/node/src/Plugin/Action/UnpublishNode.php

-<?php
-
-namespace Drupal\node\Plugin\Action;
-
-use Drupal\Core\Action\Plugin\Action\UnpublishAction;
-use Drupal\Core\Entity\EntityTypeManagerInterface;
-
-/**
- * Unpublishes a node.
- *
- * @deprecated in drupal:8.5.0 and is removed from drupal:9.0.0.
- *   Use \Drupal\Core\Action\Plugin\Action\UnpublishAction instead.
- *
- * @see \Drupal\Core\Action\Plugin\Action\UnpublishAction
- * @see https://www.drupal.org/node/2919303
- *
- * @Action(
- *   id = "node_unpublish_action",
- *   label = @Translation("Unpublish selected content"),
- *   type = "node"
- * )
- */
-class UnpublishNode extends UnpublishAction {
-
-  /**
-   * {@inheritdoc}
-   */
-  public function __construct($configuration, $plugin_id, $plugin_definition, EntityTypeManagerInterface $entity_type_manager) {
-    parent::__construct($configuration, $plugin_id, $plugin_definition, $entity_type_manager);
-    @trigger_error(__NAMESPACE__ . '\UnpublishNode is deprecated in Drupal 8.5.x, will be removed before Drupal 9.0.0. Use \Drupal\Core\Action\Plugin\Action\UnpublishAction instead. See https://www.drupal.org/node/2919303.', E_USER_DEPRECATED);
-  }
-
-}