Issue #2809535 by Lendude, martin107, dawehner, borisson_, alexpott: Convert...

Issue #2809535 by Lendude, martin107, dawehner, borisson_, alexpott: Convert AJAX part of \Drupal\system\Tests\Ajax\MultiFormTest to JavascriptTestBase

core/modules/system/src/Tests/Ajax/MultiFormTest.php → core/tests/Drupal/FunctionalJavascriptTests/Ajax/MultiFormTest.php

 <?php
 
-namespace Drupal\system\Tests\Ajax;
+namespace Drupal\FunctionalJavascriptTests\Ajax;
 
+use Drupal\Component\Render\FormattableMarkup;
 use Drupal\Core\Field\FieldStorageDefinitionInterface;
 use Drupal\field\Entity\FieldConfig;
 use Drupal\field\Entity\FieldStorageConfig;
+use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
 
 /**
  * Tests that AJAX-enabled forms work when multiple instances of the same form
@@ -12,15 +14,16 @@
  *
  * @group Ajax
  */
-class MultiFormTest extends AjaxTestBase {
+class MultiFormTest extends WebDriverTestBase {
 
   /**
-   * Modules to enable.
-   *
-   * @var array
+   * {@inheritdoc}
    */
-  public static $modules = ['form_test'];
+  public static $modules = ['node', 'form_test'];
 
+  /**
+   * {@inheritdoc}
+   */
   protected function setUp() {
     parent::setUp();
 
@@ -68,31 +71,69 @@ public function testMultiForm() {
     // each form.
     $this->drupalGet('form-test/two-instances-of-same-form');
 
-    $fields = $this->xpath($form_xpath . $field_xpath);
+    // Wait for javascript on the page to prepare the form attributes.
+    $this->assertSession()->assertWaitOnAjaxRequest();
+
+    $session = $this->getSession();
+    $page = $session->getPage();
+    $fields = $page->findAll('xpath', $form_xpath . $field_xpath);
     $this->assertEqual(count($fields), 2);
     foreach ($fields as $field) {
-      $this->assertEqual(count($field->xpath('.' . $field_items_xpath_suffix)), 1, 'Found the correct number of field items on the initial page.');
-      $this->assertFieldsByValue($field->xpath('.' . $button_xpath_suffix), NULL, 'Found the "add more" button on the initial page.');
+      $this->assertEqual(count($field->find('xpath', '.' . $field_items_xpath_suffix)), 1, 'Found the correct number of field items on the initial page.');
+      $this->assertFieldsByValue($field->find('xpath', '.' . $button_xpath_suffix), NULL, 'Found the "add more" button on the initial page.');
     }
 
-    $this->assertNoDuplicateIds(t('Initial page contains unique IDs'), 'Other');
+    $this->assertNoDuplicateIds();
 
     // Submit the "add more" button of each form twice. After each corresponding
     // page update, ensure the same as above.
 
     for ($i = 0; $i < 2; $i++) {
-      $forms = $this->xpath($form_xpath);
+      $forms = $page->find('xpath', $form_xpath);
       foreach ($forms as $offset => $form) {
-        $form_html_id = (string) $form['id'];
-        $this->drupalPostAjaxForm(NULL, [], [$button_name => $button_value], NULL, [], [], $form_html_id);
-        $form = $this->xpath($form_xpath)[$offset];
-        $field = $form->xpath('.' . $field_xpath);
-
-        $this->assertEqual(count($field[0]->xpath('.' . $field_items_xpath_suffix)), $i + 2, 'Found the correct number of field items after an AJAX submission.');
-        $this->assertFieldsByValue($field[0]->xpath('.' . $button_xpath_suffix), NULL, 'Found the "add more" button after an AJAX submission.');
-        $this->assertNoDuplicateIds(t('Updated page contains unique IDs'), 'Other');
+        $button = $form->findButton($button_value);
+        $this->assertNotNull($button, 'Add Another Item button exists');
+        $button->press();
+
+        // Wait for page update.
+        $this->assertSession()->assertWaitOnAjaxRequest();
+
+        // After AJAX request and response page will update.
+        $page_updated = $session->getPage();
+        $field = $page_updated->findAll('xpath', '.' . $field_xpath);
+        $this->assertEqual(count($field[0]->find('xpath', '.' . $field_items_xpath_suffix)), $i + 2, 'Found the correct number of field items after an AJAX submission.');
+        $this->assertFieldsByValue($field[0]->find('xpath', '.' . $button_xpath_suffix), NULL, 'Found the "add more" button after an AJAX submission.');
+        $this->assertNoDuplicateIds();
+      }
+    }
+  }
+
+  /**
+   * Asserts that each HTML ID is used for just a single element on the page.
+   *
+   * @param string $message
+   *   (optional) A message to display with the assertion.
+   */
+  protected function assertNoDuplicateIds($message = '') {
+    $args = ['@url' => $this->getUrl()];
+
+    if (!$elements = $this->xpath('//*[@id]')) {
+      $this->fail(new FormattableMarkup('The page @url contains no HTML IDs.', $args));
+      return;
+    }
+
+    $message = $message ?: new FormattableMarkup('The page @url does not contain duplicate HTML IDs', $args);
+
+    $seen_ids = [];
+    foreach ($elements as $element) {
+      $id = $element->getAttribute('id');
+      if (isset($seen_ids[$id])) {
+        $this->fail($message);
+        return;
       }
+      $seen_ids[$id] = TRUE;
     }
+    $this->assertTrue(TRUE, $message);
   }
 
 }