Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
drupal
Manage
Activity
Members
Labels
Plan
Wiki
Custom issue tracker
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
project
drupal
Commits
1c15c0f3
Verified
Commit
1c15c0f3
authored
7 months ago
by
Théodore Biadala
Browse files
Options
Downloads
Patches
Plain Diff
Issue
#3468827
by catch, smustgrave: Speed up BigPipeRegressionTest
(cherry picked from commit
aae2ffb6
)
parent
5ce4705c
No related branches found
Branches containing commit
No related tags found
2 merge requests
!11185
Issue #3477324 by andypost, alexpott: Fix usage of str_getcsv() and fgetcsv() for PHP 8.4
,
!9944
Issue #3483353: Consider making the createCopy config action optionally fail...
Pipeline
#259612
passed with warnings
7 months ago
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal
#259621
Pipeline: drupal
#259616
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php
+13
-6
13 additions, 6 deletions
.../tests/src/FunctionalJavascript/BigPipeRegressionTest.php
with
13 additions
and
6 deletions
core/modules/big_pipe/tests/src/FunctionalJavascript/BigPipeRegressionTest.php
+
13
−
6
View file @
1c15c0f3
...
...
@@ -114,13 +114,22 @@ public function testMessages_2712935(): void {
}
}
/**
* Tests edge cases with placeholder HTML.
*/
public
function
testPlaceholderHtmlEdgeCases
():
void
{
$this
->
drupalLogin
(
$this
->
drupalCreateUser
());
$this
->
doTestPlaceholderInParagraph_2802923
();
$this
->
doTestBigPipeLargeContent
();
$this
->
doTestMultipleReplacements
();
}
/**
* Ensure default BigPipe placeholder HTML cannot split paragraphs.
*
* @see https://www.drupal.org/node/2802923
*/
public
function
testPlaceholderInParagraph_2802923
():
void
{
$this
->
drupalLogin
(
$this
->
drupalCreateUser
());
protected
function
doTestPlaceholderInParagraph_2802923
():
void
{
$this
->
drupalGet
(
Url
::
fromRoute
(
'big_pipe_regression_test.2802923'
));
$this
->
assertJsCondition
(
'document.querySelectorAll(\'p\').length === 1'
);
...
...
@@ -132,9 +141,7 @@ public function testPlaceholderInParagraph_2802923(): void {
* Repeat loading of same page for two times, after second time the page is
* cached and the bug consistently reproducible.
*/
public
function
testBigPipeLargeContent
():
void
{
$user
=
$this
->
drupalCreateUser
();
$this
->
drupalLogin
(
$user
);
public
function
doTestBigPipeLargeContent
():
void
{
$assert_session
=
$this
->
assertSession
();
$this
->
drupalGet
(
Url
::
fromRoute
(
'big_pipe_test_large_content'
));
...
...
@@ -160,7 +167,7 @@ public function testBigPipeLargeContent(): void {
*
* @see https://www.drupal.org/node/3390178
*/
p
ublic
function
t
estMultipleReplacements
():
void
{
p
rotected
function
doT
estMultipleReplacements
():
void
{
$user
=
$this
->
drupalCreateUser
();
$this
->
drupalLogin
(
$user
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment