Issue #2490136 by timmillwood, Manjit.Singh, xjm, webchick, dixon_, Bojhan,...

Issue #2490136 by timmillwood, Manjit.Singh, xjm, webchick, dixon_, Bojhan, googletorp, dawehner, cilefen, jstoller, mikeburrelljr, naveenvalecha, giorgio79, platinum1, Crell, markdorison, skwashd, moshe weitzman, amateescu, jhedstrom, nateswart: Enable revisions by default

core/modules/book/config/install/node.type.book.yml

@@ -8,6 +8,6 @@ name: 'Book page'
 type: book
 description: '<em>Books</em> have a built-in hierarchical navigation. Use for handbooks or tutorials.'
 help: ''
-new_revision: false
+new_revision: true
 preview_mode: 1
 display_submitted: true

core/modules/file/src/Tests/FileOnTranslatedEntityTest.php

@@ -166,10 +166,6 @@ public function testSyncedFiles() {
     $file = File::load($replaced_second_fid);
     $this->assertTrue($file->isPermanent());
 
-    // Ensure the file status of the old second file is now temporary.
-    $file = File::load($second_fid);
-    $this->assertTrue($file->isTemporary());
-
     // Delete the third translation.
     $this->drupalPostForm('nl/node/' . $default_language_node->id() . '/delete', array(), t('Delete Dutch translation'));
 

core/modules/image/src/Tests/ImageOnTranslatedEntityTest.php

@@ -191,10 +191,6 @@ public function testSyncedImages() {
     $file = File::load($replaced_second_fid);
     $this->assertTrue($file->isPermanent());
 
-    // Ensure the file status of the old second file is now temporary.
-    $file = File::load($second_fid);
-    $this->assertTrue($file->isTemporary());
-
     // Delete the third translation.
     $this->drupalPostForm('nl/node/' . $default_language_node->id() . '/delete', array(), t('Delete Dutch translation'));
 

core/modules/node/src/Entity/NodeType.php

@@ -83,7 +83,7 @@ class NodeType extends ConfigEntityBundleBase implements NodeTypeInterface {
    *
    * @var bool
    */
-  protected $new_revision = FALSE;
+  protected $new_revision = TRUE;
 
   /**
    * The preview mode.

core/modules/node/tests/modules/node_test_config/config/install/node.type.default.yml

@@ -2,7 +2,7 @@ type: default
 name: Default
 description: 'Default description.'
 help: ''
-new_revision: false
+new_revision: true
 display_submitted: true
 preview_mode: 1
 status: true

core/modules/quickedit/src/Tests/QuickEditLoadingTest.php

@@ -67,6 +67,12 @@ protected function setUp() {
       'name' => 'Article',
     ));
 
+    // Set the node type to initially not have revisions.
+    // Testing with revisions will be done later.
+    $node_type = NodeType::load('article');
+    $node_type->setNewRevision(FALSE);
+    $node_type->save();
+
     // Create one node of the above node type using the above text format.
     $this->drupalCreateNode(array(
       'type' => 'article',

core/profiles/standard/config/install/node.type.article.yml

@@ -5,6 +5,6 @@ name: Article
 type: article
 description: 'Use <em>articles</em> for time-sensitive content like news, press releases or blog posts.'
 help: ''
-new_revision: false
+new_revision: true
 preview_mode: 1
 display_submitted: true

core/profiles/standard/config/install/node.type.page.yml

@@ -5,6 +5,6 @@ name: 'Basic page'
 type: page
 description: 'Use <em>basic pages</em> for your static content, such as an ''About us'' page.'
 help: ''
-new_revision: false
+new_revision: true
 preview_mode: 1
 display_submitted: false